Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose platform-specific PRIO_DARWIN_* constants for core type selection on macOS in os module. #103545

Closed
glyph opened this issue Apr 14, 2023 · 1 comment
Labels
OS-mac type-feature A feature request or enhancement

Comments

@glyph
Copy link
Contributor

glyph commented Apr 14, 2023

Feature or enhancement

As described in this stack overflow answer, the way to select "efficiency" vs. "performance" cores on Apple Silicon macOS machines is to use setpriority. However, you need to use custom platform-specific constants to do this, specifically, PRIO_DARWIN_BG, and either PRIO_DARWIN_THREAD or PRIO_DARWIN_PROCESS.

Pitch

It's just a few integer constants and it would expose a pretty important bit of power-efficiency/performance-tuning functionality for Python.

Previous discussion

No previous discussion anywhere, this seems like a fairly minor addition. This platform-specific functionality seems consistent with the way these functions are already treated, given that os.PRIO_* are already "Unix, not Emscripten, not WASI".

Linked PRs

@glyph glyph added the type-feature A feature request or enhancement label Apr 14, 2023
@zware zware added the OS-mac label Apr 14, 2023
ronaldoussoren added a commit to ronaldoussoren/cpython that referenced this issue May 18, 2023
ronaldoussoren added a commit that referenced this issue May 19, 2023
…s`` (#104606)

This adds a number of PRIO_DARWIN_* constants to the os module for use with os.setpriority.

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@ronaldoussoren
Copy link
Contributor

Thanks for the report.

The constants will be in 3.12. The PR cannot be back ported to older releases because this changes the API of the os module.

carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this issue May 20, 2023
* main: (30 commits)
  pythongh-103987: fix several crashes in mmap module (python#103990)
  docs: fix wrong indentation causing rendering error in dis page (python#104661)
  pythongh-94906: Support multiple steps in math.nextafter (python#103881)
  pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
  pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
  pythongh-85984: New additions and improvements to the tty library. (python#101832)
  pythongh-104659: Consolidate python examples in enum documentation (python#104665)
  pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
  pythongh-104645: fix error handling in marshal tests (python#104646)
  pythongh-104600: Make type.__type_params__ writable (python#104634)
  pythongh-104602: Add additional test for listcomp with lambda (python#104639)
  pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
  pythongh-103921: Rename "type" header in argparse docs (python#104654)
  Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
  pythongh-96522: Fix deadlock in pty.spawn (python#96639)
  pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline.  (pythonGH-104579)
  pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
  pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
  pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
  pythongh-104602: ensure all cellvars are known up front (python#104603)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-mac type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants