Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marshal tests are sloppy with error checking #104645

Closed
iritkatriel opened this issue May 19, 2023 · 0 comments · Fixed by #104646
Closed

marshal tests are sloppy with error checking #104645

iritkatriel opened this issue May 19, 2023 · 0 comments · Fixed by #104646
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@iritkatriel
Copy link
Member

iritkatriel commented May 19, 2023 •
edited by bedevere-bot
Loading

pymarshal_write_long_to_file and pymarshal_write_object_to_file pretend that PyMarshal_WriteLongToFile/PyMarshal_WriteObjectToFile can set an error.

pymarshal_read_last_object_from_file and pymarshal_read_object_from_file don't check for errors so they can call Py_BuildValue with a NULL arg.

Linked PRs
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels May 19, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue May 19, 2023
@iritkatriel
pythongh-104645: fix error handling in marshal tests
19b2600
@iritkatriel iritkatriel mentioned this issue May 19, 2023
Merged
iritkatriel added a commit to iritkatriel/cpython that referenced this issue May 19, 2023
@iritkatriel
Revert "pythongh-104645: fix error handling in marshal tests"
e9978b8 
This reverts commit 19b2600.
iritkatriel added a commit that referenced this issue May 19, 2023
@iritkatriel
gh-104645: fix error handling in marshal tests (#104646)
ac56a85
@bedevere-bot bedevere-bot mentioned this issue May 19, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 19, 2023
@iritkatriel @miss-islington
pythongh-104645: fix error handling in marshal tests (pythonGH-104646)
e1768d9 
(cherry picked from commit ac56a85)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this issue May 19, 2023
@miss-islington @iritkatriel
[3.11] gh-104645: fix error handling in marshal tests (GH-104646) (#1…
d78c3bc 
…04663)

gh-104645: fix error handling in marshal tests (GH-104646)
(cherry picked from commit ac56a85)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this issue May 20, 2023
@carljm
Merge branch 'main' into gsallam/main
ea5965a 
* main: (30 commits)
  pythongh-103987: fix several crashes in mmap module (python#103990)
  docs: fix wrong indentation causing rendering error in dis page (python#104661)
  pythongh-94906: Support multiple steps in math.nextafter (python#103881)
  pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
  pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
  pythongh-85984: New additions and improvements to the tty library. (python#101832)
  pythongh-104659: Consolidate python examples in enum documentation (python#104665)
  pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
  pythongh-104645: fix error handling in marshal tests (python#104646)
  pythongh-104600: Make type.__type_params__ writable (python#104634)
  pythongh-104602: Add additional test for listcomp with lambda (python#104639)
  pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
  pythongh-103921: Rename "type" header in argparse docs (python#104654)
  Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
  pythongh-96522: Fix deadlock in pty.spawn (python#96639)
  pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline.  (pythonGH-104579)
  pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
  pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
  pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
  pythongh-104602: ensure all cellvars are known up front (python#104603)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-104645: fix error handling in marshal tests iritkatriel/cpython
1 participant
@iritkatriel