Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tokenize error handling #104169

Closed
pablogsal opened this issue May 4, 2023 · 2 comments
Closed

Improve tokenize error handling #104169

pablogsal opened this issue May 4, 2023 · 2 comments
Assignees
@pablogsal @lysnikolaou

Comments

@pablogsal
Copy link
Member

pablogsal commented May 4, 2023 •
edited by bedevere-app bot

There has been quite a lot of instances were poor error handling in the tokenizer leads to crashes or errors being overwritten. We should not rely on continuous patches to every single individual issue but we should improve the situation with more robust infrastructure.

Linked PRs
@bedevere-bot bedevere-bot mentioned this issue May 4, 2023
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue May 4, 2023
@pablogsal
pythongh-104169: Ensure the tokenizer doesn't overwrite previous errors
aefa494
pablogsal added a commit that referenced this issue May 4, 2023
@pablogsal
gh-104169: Ensure the tokenizer doesn't overwrite previous errors (#1…
eba64d2 
…04170)
@pablogsal
Copy link
Member Author

CC: @lysnikolaou

lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue Oct 11, 2023
@lysnikolaou
pythongh-104169: Refactor tokenizer into lexer and wrappers
99a2b40 
* The lexer, which include the actual lexeme producing logic, goes into
  the `lexer` directory.
* The wrappers, one wrapper per input mode (file, string, utf-8, and
  readline), go into the `tokenizer` directory and include logic for
  creating a lexer instance and managing the buffer for different modes.
@bedevere-app bedevere-app bot mentioned this issue Oct 11, 2023
Merged
lysnikolaou added a commit that referenced this issue Oct 11, 2023
@lysnikolaou @pablogsal @blurb-it
gh-104169: Refactor tokenizer into lexer and wrappers (#110684)
01481f2 
* The lexer, which include the actual lexeme producing logic, goes into
  the `lexer` directory.
* The wrappers, one wrapper per input mode (file, string, utf-8, and
  readline), go into the `tokenizer` directory and include logic for
  creating a lexer instance and managing the buffer for different modes.
---------

Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue Oct 11, 2023
@lysnikolaou
pythongh-104169: Fix test_peg_generator after tokenizer refactoring
2253a49
@bedevere-app bedevere-app bot mentioned this issue Oct 11, 2023
Merged
lysnikolaou added a commit that referenced this issue Oct 12, 2023
@lysnikolaou
gh-104169: Fix test_peg_generator after tokenizer refactoring (#110727)
17d6554 
* Fix test_peg_generator after tokenizer refactoring
* Remove references to tokenizer.c in comments etc.
@hugovk
Copy link
Member

hugovk commented Nov 10, 2023

Ready to close? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablogsal pablogsal

@lysnikolaou lysnikolaou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugovk @pablogsal @lysnikolaou