gh-104169: Refactor tokenizer into lexer and wrappers #110684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The lexer, which include the actual lexeme producing logic, goes into the `lexer` directory. * The wrappers, one wrapper per input mode (file, string, utf-8, and readline), go into the `tokenizer` directory and include logic for creating a lexer instance and managing the buffer for different modes.
lysnikolaou
force-pushed
the
tokenizer-lexer-refactoring
branch
from
3661d27
to
a4190a9
Compare
lysnikolaou
commented
Oct 11, 2023
| if (tok->done != E_OK) { | ||
| return EOF; | ||
| } | ||
| rc = tok->underflow(tok); |
There was a problem hiding this comment.
@pablogsal This is the only change I did here. Instead of calling underflow according to stuff like tok->str, every tokenizer type passes in a callable that handles underflow in _PyTokenizer_From*.
pablogsal
approved these changes
Oct 11, 2023
|
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lexerdirectory.tokenizerdirectory and include logic for creating a lexer instance and managing the buffer for different modes.