Rework test_ctypes #105751

vstinner · 2023-06-13T21:20:27Z

The ctypes module was first maintained outside Python, then moved into Python stdlib. Its test suite wasn't cleaned recently. I create this issue to track work on this topic.

Linked PRs

The text was updated successfully, but these errors were encountered:

test_ctypes now gets attributes specific to Windows from the ctypes module, rather than relying on "from ctypes import *".

test_ctypes now gets attributes specific to Windows from the ctypes module, rather than relying on "from ctypes import *". Attributes: * ctypes.WINFUNCTYPE * ctypes.WinDLL * ctypes.windll * ctypes.WinError * ctypes.get_last_error() * ctypes.set_last_error()

test_ctypes now gets attributes specific to Windows from the ctypes module, rather than relying on "from ctypes import *". Attributes: * ctypes.WINFUNCTYPE * ctypes.WinDLL * ctypes.windll * ctypes.WinError * ctypes.get_last_error() * ctypes.set_last_error() * ctypes.oledll

test_ctypes now gets attributes specific to Windows from the ctypes module, rather than relying on "from ctypes import *". Attributes: * ctypes.FormatError * ctypes.WINFUNCTYPE * ctypes.WinError * ctypes.WinDLL * ctypes.windll * ctypes.oledll * ctypes.get_last_error() * ctypes.set_last_error()

c_ulonglong and c_bool are now always available.

Moroever, c_ulonglong and c_bool are always available.

test_ctypes now gets attributes specific to Windows from the ctypes module, rather than relying on "from ctypes import *". Attributes: * ctypes.FormatError * ctypes.WINFUNCTYPE * ctypes.WinError * ctypes.WinDLL * ctypes.windll * ctypes.oledll * ctypes.get_last_error() * ctypes.set_last_error()

Moroever, c_ulonglong and c_bool are always available.

Using "import *" prevents linters like pyflakes to detect symbols (variables, functions) used being imported. Replace c_voidp with c_void_p.

Using "import *" prevents linters like pyflakes to detect undefined names (usually missing imports). Replace c_voidp with c_void_p.

* Replace operator.delitem(obj, index) with "del obj[index]". * Replace operator.setitem(obj, index, value) with "obj[index] = value". * Replace delattr(obj, "attr) with del obj.attr. * Replace grc() with sys.getrefcount() for readability.

* Replace operator.delitem(obj, index) with "del obj[index]". * Replace operator.setitem(obj, index, value) with "obj[index] = value". * Replace delattr(obj, "attr) with "del obj.attr". * Replace grc() with sys.getrefcount() for readability.

Remove most @need_symbol('...') decorator since requested symbols are now always always available. Use directly the @unittest.skipUnless() decorator for Windows types: * ctypes.WINFUNCTYPE * ctypes.oledll

Remove the @need_symbol('...') decorator of test.test_ctypes since requested symbols are now always always available in ctypes. Use directly the @unittest.skipUnless() decorator for the two types only available on Windows: * ctypes.WINFUNCTYPE * ctypes.oledll

Remove the @need_symbol('...') decorator of test.test_ctypes since requested symbols are now always always available in ctypes. Use the @unittest.skipUnless() decorator directly for the two types only available on Windows: * ctypes.WINFUNCTYPE * ctypes.oledll

* Replace operator.delitem(obj, index) with "del obj[index]". * Replace operator.setitem(obj, index, value) with "obj[index] = value". * Replace delattr(obj, "attr) with "del obj.attr". * Replace grc() with sys.getrefcount() for readability.

Reenable 3 tests: * test_overflow() * test_basic_wstrings() * test_toolong() Changes: * Replace sys.maxint with sys.maxsize * Replace c_wstring() with create_unicode_buffer() * Update issue number

Reenable 3 tests: * test_overflow() * test_basic_wstrings() * test_toolong()

* Remove "except: print(tp); raise" debug code. * Remove unused NoNullHandle() function. * Remove commented code.

* The following tests were disabled since the initial ctypes commit in 2006, commit babddfc: * Callbacks.test_char_p() * DeletePointerTestCase.test_X() * NumberTestCase.test_perf() * StructureTestCase.test_subclass_creation() * Tests.test_X() of test_byteswap * NumberTestCase.test_bool_from_address() was disabled in 2007 by commit 5dc4fe0. * Remove check_perf() and run_test() of test_numbers.

The MACHINE variable is no longer used in test_structures.

* Remove "except: print(tp); raise" debug code. * Remove unused NoNullHandle() function. * Remove commented code.

Reenable 3 tests: * test_overflow() * test_basic_wstrings() * test_toolong()

The MACHINE variable is no longer used in test_structures.

* The following tests were disabled since the initial ctypes commit in 2006, commit babddfc: * Callbacks.test_char_p() * DeletePointerTestCase.test_X() * NumberTestCase.test_perf() * StructureTestCase.test_subclass_creation() * Tests.test_X() of test_byteswap * NumberTestCase.test_bool_from_address() was disabled in 2007 by commit 5dc4fe0. * Remove check_perf() and run_test() of test_numbers.

* main: (57 commits) pythongh-105831: Fix NEWS blurb from pythongh-105828 (python#105833) pythongh-105820: Fix tok_mode expression buffer in file & readline tokenizer (python#105828) pythongh-105751, test_ctypes: Remove disabled tests (python#105826) pythongh-105821: Use a raw f-string in test_httpservers.py (python#105822) pythongh-105751: Remove platform usage in test_ctypes (python#105819) pythongh-105751: Reenable disable test_ctypes tests (python#105818) pythongh-105751: Remove dead code in test_ctypes (python#105817) More reorganisation of the typing docs (python#105787) Improve docs for `typing.dataclass_transform` (python#105792) pythonGH-89812: Churn `pathlib.Path` test methods (python#105807) pythongh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (python#105801) pythongh-105751: Cleanup test_ctypes imports (python#105803) pythongh-105481: add HAS_JUMP flag to opcode metadata (python#105791) pythongh-105751: test_ctypes avoids the operator module (pythonGH-105797) pythongh-105751: test_ctypes: Remove @need_symbol decorator (pythonGH-105798) pythongh-104909: Implement conditional stack effects for macros (python#105748) pythongh-75905: Remove test_xmlrpc_net: skipped since 2017 (python#105796) pythongh-105481: Fix types and a bug for pseudos (python#105788) Update DSL docs for cases generator (python#105753) pythonGH-77273: Better bytecodes for f-strings (pythonGH-6132) ...

vstinner · 2023-06-16T13:09:14Z

Ok, I think that I merged enough changes. I close the issue :-)

…105826) * The following tests were disabled since the initial ctypes commit in 2006, commit babddfc: * Callbacks.test_char_p() * DeletePointerTestCase.test_X() * NumberTestCase.test_perf() * StructureTestCase.test_subclass_creation() * Tests.test_X() of test_byteswap * NumberTestCase.test_bool_from_address() was disabled in 2007 by commit 5dc4fe0. * Remove check_perf() and run_test() of test_numbers. (cherry picked from commit 8f10140) Co-authored-by: Victor Stinner <vstinner@python.org>

…7483) * The following tests were disabled since the initial ctypes commit in 2006, commit babddfc: * Callbacks.test_char_p() * DeletePointerTestCase.test_X() * NumberTestCase.test_perf() * StructureTestCase.test_subclass_creation() * Tests.test_X() of test_byteswap * NumberTestCase.test_bool_from_address() was disabled in 2007 by commit 5dc4fe0. * Remove check_perf() and run_test() of test_numbers. (cherry picked from commit 8f10140) Co-authored-by: Victor Stinner <vstinner@python.org>

…7484) * The following tests were disabled since the initial ctypes commit in 2006, commit babddfc: * Callbacks.test_char_p() * DeletePointerTestCase.test_X() * NumberTestCase.test_perf() * StructureTestCase.test_subclass_creation() * Tests.test_X() of test_byteswap * NumberTestCase.test_bool_from_address() was disabled in 2007 by commit 5dc4fe0. * Remove check_perf() and run_test() of test_numbers. (cherry picked from commit 8f10140) Co-authored-by: Victor Stinner <vstinner@python.org>

…107460)

…types tests (pythonGH-107460) (cherry picked from commit 520efec) Co-authored-by: Tomas R <tomas.roun8@gmail.com>

…tests (GH-107460) (#107502) (cherry picked from commit 520efec) Co-authored-by: Tomas R <tomas.roun8@gmail.com>

…tests (GH-107460) (#107501) (cherry picked from commit 520efec) Co-authored-by: Tomas R <tomas.roun8@gmail.com>

vstinner added the type-bug An unexpected behavior, bug, or error label Jun 13, 2023

AlexWaygood added tests Tests in the Lib/test dir topic-ctypes labels Jun 13, 2023

vstinner added a commit to vstinner/cpython that referenced this issue Jun 13, 2023

pythongh-105751: test_ctypes gets Windows attrs from ctypes

6453eec

test_ctypes now gets attributes specific to Windows from the ctypes module, rather than relying on "from ctypes import *".

vstinner added a commit to vstinner/cpython that referenced this issue Jun 13, 2023

pythongh-105751: test_ctypes gets Windows attrs from ctypes

4541af0

test_ctypes now gets attributes specific to Windows from the ctypes module, rather than relying on "from ctypes import *".

vstinner added a commit to vstinner/cpython that referenced this issue Jun 13, 2023

pythongh-105751: test_ctypes gets Windows attrs from ctypes

43ca8ff

test_ctypes now gets attributes specific to Windows from the ctypes module, rather than relying on "from ctypes import *".

bedevere-bot mentioned this issue Jun 13, 2023

gh-105751: test_ctypes gets Windows attrs from ctypes #105758

Merged

vstinner added a commit to vstinner/cpython that referenced this issue Jun 14, 2023

pythongh-105751: test_ctypes.test_numbers uses top level imports

bcaed4f

c_ulonglong and c_bool are now always available.

vstinner added a commit to vstinner/cpython that referenced this issue Jun 14, 2023

pythongh-105751: test_ctypes.test_numbers uses top level imports

bb343a8

Moroever, c_ulonglong and c_bool are always available.

bedevere-bot mentioned this issue Jun 14, 2023

gh-105751: test_ctypes.test_numbers uses top level imports #105762

Merged

vstinner added a commit that referenced this issue Jun 14, 2023

gh-105751: test_ctypes.test_numbers uses top level imports (#105762)

381a1dc

Moroever, c_ulonglong and c_bool are always available.

vstinner added a commit to vstinner/cpython that referenced this issue Jun 14, 2023

pythongh-105751: test_ctypes avoids "from ctypes import *"

c640c34

Using "import *" prevents linters like pyflakes to detect symbols (variables, functions) used being imported. Replace c_voidp with c_void_p.

bedevere-bot mentioned this issue Jun 14, 2023

gh-105751: test_ctypes avoids "from ctypes import *" #105768

Merged

vstinner mentioned this issue Jun 14, 2023

Remove unused imports (June 2023) #105407

Closed

vstinner added a commit that referenced this issue Jun 14, 2023

gh-105751: test_ctypes avoids "from ctypes import *" (#105768)

b95de96

Using "import *" prevents linters like pyflakes to detect undefined names (usually missing imports). Replace c_voidp with c_void_p.

bedevere-bot mentioned this issue Jun 14, 2023

gh-105751: test_ctypes avoids the operator module #105797

Merged

bedevere-bot mentioned this issue Jun 14, 2023

gh-105751: test_ctypes: Remove @need_symbol decorator #105798

Merged

vstinner added a commit to vstinner/cpython that referenced this issue Jun 15, 2023

pythongh-105751: Reenable disable test_ctypes tests

61cbdfb

Reenable 3 tests: * test_overflow() * test_basic_wstrings() * test_toolong()

bedevere-bot mentioned this issue Jun 15, 2023

gh-105751: Reenable disable test_ctypes tests #105818

Merged

vstinner added a commit to vstinner/cpython that referenced this issue Jun 15, 2023

pythongh-105751, test_ctypes: Remove dead code

2ef40c6

* Remove "except: print(tp); raise" debug code. * Remove unused NoNullHandle() function. * Remove commented code.

vstinner added a commit to vstinner/cpython that referenced this issue Jun 15, 2023

pythongh-105751: Remove platform usage in test_ctypes

f65d294

The MACHINE variable is no longer used in test_structures.

bedevere-bot mentioned this issue Jun 15, 2023

gh-105751: Remove platform usage in test_ctypes #105819

Merged

vstinner added a commit that referenced this issue Jun 15, 2023

gh-105751: Remove dead code in test_ctypes (#105817)

0841ca7

* Remove "except: print(tp); raise" debug code. * Remove unused NoNullHandle() function. * Remove commented code.

vstinner added a commit that referenced this issue Jun 15, 2023

gh-105751: Reenable disable test_ctypes tests (#105818)

b496ff3

Reenable 3 tests: * test_overflow() * test_basic_wstrings() * test_toolong()

vstinner added a commit that referenced this issue Jun 15, 2023

gh-105751: Remove platform usage in test_ctypes (#105819)

c5111ae

The MACHINE variable is no longer used in test_structures.

bedevere-bot mentioned this issue Jun 15, 2023

gh-105751, test_ctypes: Remove disabled tests #105826

Merged

vstinner closed this as completed Jun 16, 2023

bedevere-bot mentioned this issue Jul 31, 2023

[3.12] gh-105751, test_ctypes: Remove disabled tests (GH-105826) #107483

Merged

bedevere-bot mentioned this issue Jul 31, 2023

[3.11] gh-105751, test_ctypes: Remove disabled tests (GH-105826) #107484

Merged

bedevere-bot mentioned this issue Jul 31, 2023

gh-105751: Remove obsolete object base class in some ctypes tests #107460

Merged

ambv pushed a commit that referenced this issue Jul 31, 2023

gh-105751: Remove obsolete object base class in some ctypes tests (#…

520efec

…107460)

ambv pushed a commit to ambv/cpython that referenced this issue Jul 31, 2023

[3.12] pythongh-105751: Remove obsolete object base class in some c…

b4cc248

…types tests (pythonGH-107460) (cherry picked from commit 520efec) Co-authored-by: Tomas R <tomas.roun8@gmail.com>

bedevere-bot mentioned this issue Jul 31, 2023

[3.12] gh-105751: Remove obsolete object base class in some ctypes tests (GH-107460) #107501

Merged

ambv pushed a commit to ambv/cpython that referenced this issue Jul 31, 2023

[3.11] pythongh-105751: Remove obsolete object base class in some c…

8845ce1

…types tests (pythonGH-107460) (cherry picked from commit 520efec) Co-authored-by: Tomas R <tomas.roun8@gmail.com>

bedevere-bot mentioned this issue Jul 31, 2023

[3.11] gh-105751: Remove obsolete object base class in some ctypes tests (GH-107460) #107502

Merged

ambv added a commit that referenced this issue Jul 31, 2023

[3.11] gh-105751: Remove obsolete object base class in some ctypes …

1b40431

…tests (GH-107460) (#107502) (cherry picked from commit 520efec) Co-authored-by: Tomas R <tomas.roun8@gmail.com>

ambv added a commit that referenced this issue Jul 31, 2023

[3.12] gh-105751: Remove obsolete object base class in some ctypes …

831fd19

…tests (GH-107460) (#107501) (cherry picked from commit 520efec) Co-authored-by: Tomas R <tomas.roun8@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework test_ctypes #105751

Rework test_ctypes #105751

vstinner commented Jun 13, 2023 •

edited by bedevere-bot

vstinner commented Jun 16, 2023

Rework test_ctypes #105751

Rework test_ctypes #105751

Comments

vstinner commented Jun 13, 2023 • edited by bedevere-bot

Linked PRs

vstinner commented Jun 16, 2023

vstinner commented Jun 13, 2023 •

edited by bedevere-bot