Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy and deepcopy fail to copy ipaddress scope_id #110196

Closed
becarpenter opened this issue Oct 2, 2023 · 2 comments
Closed

copy and deepcopy fail to copy ipaddress scope_id #110196

becarpenter opened this issue Oct 2, 2023 · 2 comments
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@becarpenter
Copy link

becarpenter commented Oct 2, 2023 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

copy and deepcopy fail to copy ipaddress scope_id

import ipaddress, copy
a = ipaddress.IPv6Address('fe80::abc%def')
a.scope_id  #shows 'def'
c = copy.copy(a)
c.scope_id  #shows null, should show 'def'
d = copy.deepcopy(a)
d.scope_id  #shows null, should show 'def'

CPython versions tested on:

3.9, 3.11

Operating systems tested on:

Linux, Windows

Linked PRs
@becarpenter becarpenter added the type-bug An unexpected behavior, bug, or error label Oct 2, 2023
@bedevere-app bedevere-app bot mentioned this issue Oct 2, 2023
Merged
@gaogaotiantian
Copy link
Member

IPv6Address now inherits __reduce__ from _BaseAddress which will only keep the ip info (so scope_id is discarded). I just added a new __reduce__ method for it to solve this.

@becarpenter
Copy link
Author

Thanks for quick response.

@furkanonder furkanonder added the stdlib Python modules in the Lib dir label Oct 4, 2023
serhiy-storchaka pushed a commit that referenced this issue Oct 22, 2023
@gaogaotiantian
gh-110196: Fix ipaddress.IPv6Address.__reduce__ (GH-110198)
767f416
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 22, 2023
@gaogaotiantian @miss-islington
pythongh-110196: Fix ipaddress.IPv6Address.__reduce__ (pythonGH-110198)
eb1b0f2 
(cherry picked from commit 767f416)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app bedevere-app bot mentioned this issue Oct 22, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 22, 2023
@gaogaotiantian @miss-islington
pythongh-110196: Fix ipaddress.IPv6Address.__reduce__ (pythonGH-110198)
3147905 
(cherry picked from commit 767f416)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app bedevere-app bot mentioned this issue Oct 22, 2023
Merged
serhiy-storchaka pushed a commit that referenced this issue Oct 22, 2023
@miss-islington @gaogaotiantian
[3.11] gh-110196: Fix ipaddress.IPv6Address.__reduce__ (GH-110198) (G…
3c3c489 
…H-111190)

(cherry picked from commit 767f416)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
serhiy-storchaka pushed a commit that referenced this issue Oct 22, 2023
@miss-islington @gaogaotiantian
[3.12] gh-110196: Fix ipaddress.IPv6Address.__reduce__ (GH-110198) (G…
9e73c71 
…H-111191)

(cherry picked from commit 767f416)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@furkanonder furkanonder added 3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes labels Oct 26, 2023
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@gaogaotiantian @aisk
pythongh-110196: Fix ipaddress.IPv6Address.__reduce__ (pythonGH-110198)
90feee7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
Pickle and copy issues 🥒
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@becarpenter @gaogaotiantian @furkanonder