Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-110196: Fix ipaddress.IPv6Address.__reduce__ #110198

Merged
merged 4 commits into from
Oct 22, 2023
Merged

gh-110196: Fix ipaddress.IPv6Address.__reduce__ #110198

merged 4 commits into from
Oct 22, 2023

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Oct 2, 2023 •
edited by bedevere-app bot
Loading

IPv6Address should keep scope_id. Inheriting __reduce__ from _BaseAddress will only keep the ip address.

@bedevere-app bedevere-app bot mentioned this pull request Oct 2, 2023
Closed
sobolevn
sobolevn reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also update pickle_test to check for some attrs?

Lib/test/test_ipaddress.py Outdated Show resolved Hide resolved
@gaogaotiantian
Copy link
Member Author

Maybe also update pickle_test to check for some attrs?

Makes sense! Test added.

@gaogaotiantian
Copy link
Member Author

@gpshead not sure who I should ask for the review. You have reviewed changes to this file a couple of times, could you take a look at this? Thanks.

@furkanonder furkanonder added the stdlib Python modules in the Lib dir label Oct 17, 2023
serhiy-storchaka
serhiy-storchaka approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 767f416 into python:main Oct 22, 2023
21 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Oct 22, 2023
@miss-islington-app
Copy link

Thanks @gaogaotiantian for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @gaogaotiantian for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2023
@gaogaotiantian @miss-islington
pythongh-110196: Fix ipaddress.IPv6Address.__reduce__ (pythonGH-110198)
eb1b0f2 
(cherry picked from commit 767f416)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2023
@gaogaotiantian @miss-islington
pythongh-110196: Fix ipaddress.IPv6Address.__reduce__ (pythonGH-110198)
3147905 
(cherry picked from commit 767f416)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 22, 2023

GH-111190 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 22, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 22, 2023

GH-111191 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 22, 2023
serhiy-storchaka pushed a commit that referenced this pull request Oct 22, 2023
@miss-islington @gaogaotiantian
[3.11] gh-110196: Fix ipaddress.IPv6Address.__reduce__ (GH-110198) (G…
3c3c489 
…H-111190)

(cherry picked from commit 767f416)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Oct 22, 2023
@miss-islington @gaogaotiantian
[3.12] gh-110196: Fix ipaddress.IPv6Address.__reduce__ (GH-110198) (G…
9e73c71 
…H-111191)

(cherry picked from commit 767f416)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@furkanonder furkanonder added the type-bug An unexpected behavior, bug, or error label Oct 26, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@gaogaotiantian @aisk
pythongh-110196: Fix ipaddress.IPv6Address.__reduce__ (pythonGH-110198)
90feee7
@gaogaotiantian gaogaotiantian deleted the fix-ipaddress-reduce branch June 17, 2024 17:45
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@gaogaotiantian @Glyphack
pythongh-110196: Fix ipaddress.IPv6Address.__reduce__ (pythonGH-110198)
b710b9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaogaotiantian @serhiy-storchaka @sobolevn @furkanonder