Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_multiprocessing.test_empty_authkey triggers env changed failure #116439

Closed
colesbury opened this issue Mar 6, 2024 · 1 comment
Closed
Assignees
Labels
tests Tests in the Lib/test dir

Comments

@colesbury
Copy link
Contributor

colesbury commented Mar 6, 2024

The test starts a thread but doesn't join it, which can lead to test failures with "ENV CHANGED"

with self.connection.Listener(authkey=key) as listener:
threading.Thread(target=run, args=(listener.address, key)).start()
with listener.accept() as d:
self.assertEqual(d.recv(), 1729)

See also #25845

From https://buildbot.python.org/all/#/builders/249/builds/7957/steps/5/logs/stdio:

...
test_empty_authkey (test.test_multiprocessing_fork.test_processes.WithProcessesTestListener.test_empty_authkey) ... ok
test_multiple_bind (test.test_multiprocessing_fork.test_processes.WithProcessesTestListener.test_multiple_bind) ... ok
Warning -- Dangling threads: {<Thread(Thread-13 (run), started 139968890533568)>}
...

Linked PRs

@colesbury colesbury added the tests Tests in the Lib/test dir label Mar 6, 2024
@colesbury colesbury self-assigned this Mar 6, 2024
colesbury added a commit to colesbury/cpython that referenced this issue Mar 6, 2024
@colesbury
Copy link
Contributor Author

Already fixed in #116434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

1 participant