bpo-43952: Fix multiprocessing Listener authkey bug #25845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguendes
changed the title
|
@aeros You may be interested in reviewing this, though it's quite a low-priority bugfix. |
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @miguendes for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @miguendes for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2024
Listener.accept() no longer hangs when authkey is an empty bytes object. (cherry picked from commit 686ec17) Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
|
GH-115994 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 27, 2024
Listener.accept() no longer hangs when authkey is an empty bytes object. (cherry picked from commit 686ec17) Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
|
GH-115995 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 27, 2024
…GH-115995) Listener.accept() no longer hangs when authkey is an empty bytes object. (cherry picked from commit 686ec17) Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 27, 2024
…GH-115994) Listener.accept() no longer hangs when authkey is an empty bytes object. (cherry picked from commit 686ec17) Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
Listener.accept() no longer hangs when authkey is an empty bytes object.
gpshead
added a commit
to gpshead/cpython
that referenced
this pull request
Mar 6, 2024
Potentially introduced by python#25845 not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to: ``` 1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes 2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes ```
gpshead
added a commit
that referenced
this pull request
Mar 6, 2024
Fix some test_multiprocessing flakiness. Potentially introduced by #25845 not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to: ``` 1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes 2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes ```
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 6, 2024
…6434) Fix some test_multiprocessing flakiness. Potentially introduced by python#25845 not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to: ``` 1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes 2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes ``` (cherry picked from commit ea1803e) Co-authored-by: Gregory P. Smith <greg@krypto.org>
This was referenced Mar 6, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 6, 2024
…6434) Fix some test_multiprocessing flakiness. Potentially introduced by python#25845 not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to: ``` 1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes 2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes ``` (cherry picked from commit ea1803e) Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead
added a commit
that referenced
this pull request
Mar 6, 2024
…GH-116440) Fix some test_multiprocessing flakiness. Potentially introduced by #25845 not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to: ``` 1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes 2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes ``` (cherry picked from commit ea1803e) Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead
added a commit
that referenced
this pull request
Mar 6, 2024
…GH-116441) Fix some test_multiprocessing flakiness. Potentially introduced by #25845 not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to: ``` 1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes 2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes ``` (cherry picked from commit ea1803e) Co-authored-by: Gregory P. Smith <greg@krypto.org>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
Listener.accept() no longer hangs when authkey is an empty bytes object.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
Fix some test_multiprocessing flakiness. Potentially introduced by python#25845 not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to: ``` 1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes 2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes ```
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Listener.accept() no longer hangs when authkey is an empty bytes object.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Fix some test_multiprocessing flakiness. Potentially introduced by python#25845 not joining that thread likely leads to recently observed "environment changed" logically passing but overall failing tests seen on some buildbots similar to: ``` 1 test altered the execution environment (env changed): test.test_multiprocessing_fork.test_processes 2 re-run tests: test.test_multiprocessing_fork.test_processes test.test_multiprocessing_forkserver.test_processes ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43952