Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_ioctl is skipped because of setsid() #119273

Closed
vstinner opened this issue May 20, 2024 · 0 comments
Closed

test_ioctl is skipped because of setsid() #119273

vstinner opened this issue May 20, 2024 · 0 comments
Labels
tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

vstinner commented May 20, 2024

Python test runner "regrtest" uses process groups to be able to kill child processes of worker processes. Tests are run in subprocesses to run them in parallel and to catch bugs.

Problem: if setsid() is called (after fork), test_ioctl fails to open /dev/tty.

I propose to not use setsid() when running tests using TTY, such as test_ioctl.

Linked PRs

vstinner added a commit to vstinner/cpython that referenced this issue May 20, 2024
Python test runner no longer runs tests using TTY (ex: test_ioctl) in
a process group (using setsid()). Previously, tests using TTY were
skipped.
@aisk aisk added the tests Tests in the Lib/test dir label May 21, 2024
vstinner added a commit that referenced this issue May 29, 2024
Python test runner no longer runs tests using TTY (ex: test_ioctl) in
a process group (using setsid()). Previously, tests using TTY were
skipped.
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
Python test runner no longer runs tests using TTY (ex: test_ioctl) in
a process group (using setsid()). Previously, tests using TTY were
skipped.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
Python test runner no longer runs tests using TTY (ex: test_ioctl) in
a process group (using setsid()). Previously, tests using TTY were
skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

2 participants