Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idlelib/help.html is outdated #120360

Open
sobolevn opened this issue Jun 11, 2024 · 7 comments
Open

idlelib/help.html is outdated #120360

sobolevn opened this issue Jun 11, 2024 · 7 comments
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes docs Documentation in the Doc dir stdlib Python modules in the Lib dir topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 11, 2024

Bug report

There are multiple problems with it:

  1. It mentions outdated Python version:
    <title>IDLE &#8212; Python 3.13.0a2 documentation</title><meta name="viewport" content="width=device-width, initial-scale=1.0">
    Right now it should be Python 3.14a0
  2. Is is not rebuilt / executed during release process
  3. It is not executed to check that generated files are up-to-date with the source ones (Doc/library/idle.rst in this case) in CI
  4. help.html does not contain a comment that it is generated (and from what)
  5. help.html is not marked as generated in .gitattributes

CC @terryjreedy

Found while reviewing #120338 (review)

Linked PRs

@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir stdlib Python modules in the Lib dir topic-IDLE 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Jun 11, 2024
@nineteendo
Copy link
Contributor

Hmm, this change was previously rejected:

Remove idlelib/help.html from this PR. The change is wrong.

@terryjreedy
Copy link
Member

  1. The viewer only displays the text itself, as seen online, and skips some html header and footer lines. I plan to move the skipping code from the viewer to the copier so only the part viewed gets checked in. This will eliminate 'mid-dated' comments. (This may be part of some issue or draft issue.)
  2. As long as .rst changes are propagated to help.html in the same PR, nothing is needed on release.
  3. So checking that help.html is updated when idle.rst is would be excellent. I have no idea how to do that. Do you, Nikita?
  4. I am thinking about what footer to add.
  5. What is the effect of adding something to .getatttributes?

@terryjreedy
Copy link
Member

terryjreedy commented Jun 16, 2024

  1. To aid propagation, PR adds me as idle.rst codeowner.

terryjreedy added a commit that referenced this issue Jun 16, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 16, 2024
Add self as IDLE doc owner
(cherry picked from commit cf49ef7)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 16, 2024
Add self as IDLE doc owner
(cherry picked from commit cf49ef7)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this issue Jun 16, 2024
gh-120360: Add self as IDLE doc owner (GH-120571)

Add self as IDLE doc owner
(cherry picked from commit cf49ef7)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this issue Jun 16, 2024
gh-120360: Add self as IDLE doc owner (GH-120571)

Add self as IDLE doc owner
(cherry picked from commit cf49ef7)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@sobolevn
Copy link
Member Author

sobolevn commented Jun 16, 2024

  1. So checking that help.html is updated when idle.rst is would be excellent. I have no idea how to do that. Do you, Nikita?

I guess that we have similar things:

What is the effect of adding something to .getatttributes?

The diff will be collapsed by default. It is only useful when we verify that this file is up-to-date.

@terryjreedy
Copy link
Member

"simple python test": I will add to test_help.py something like

def test_up_to_date(self):
    if <idle.rst exists>:  # in repository
         self.assertGreater(mdate(help.html), mdate(idle.rst)
    else:
        <skip>

"The diff will be collapsed by default." I don't understand this in the given context.

@sobolevn
Copy link
Member Author

"The diff will be collapsed by default." I don't understand this in the given context.

Let's look at https://github.com/python/cpython/pull/120379/files

Here's how regular diff looks like:
Снимок экрана 2024-06-17 в 10 06 34

Here's how collapsed diff looks like (Modules/clinic/_operator.c.h is "generated"):
Снимок экрана 2024-06-17 в 10 06 19

@terryjreedy
Copy link
Member

Thank you. Since I routinely check the .html diff, and it is usually not very big, I don't think the suppression in needed.

mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes docs Documentation in the Doc dir stdlib Python modules in the Lib dir topic-IDLE type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants