Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"idna" encoding (drawing unicodedata) necessary in httplib? #43236

Closed
kxroberto mannequin opened this issue Apr 18, 2006 · 4 comments
Closed

"idna" encoding (drawing unicodedata) necessary in httplib? #43236

kxroberto mannequin opened this issue Apr 18, 2006 · 4 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@kxroberto
Copy link
Mannequin

kxroberto mannequin commented Apr 18, 2006

BPO 1472176
Nosy @malemburg, @birkenfeld
Files
  • httplib_idna.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2006-05-03.18:03:41.000>
    created_at = <Date 2006-04-18.09:28:35.000>
    labels = ['type-feature', 'library']
    title = '"idna" encoding (drawing unicodedata) necessary in httplib?'
    updated_at = <Date 2006-05-03.18:03:41.000>
    user = 'https://bugs.python.org/kxroberto'

    bugs.python.org fields:

    activity = <Date 2006-05-03.18:03:41.000>
    actor = 'georg.brandl'
    assignee = 'none'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2006-04-18.09:28:35.000>
    creator = 'kxroberto'
    dependencies = []
    files = ['8271']
    hgrepos = []
    issue_num = 1472176
    keywords = []
    message_count = 4.0
    messages = ['54781', '54782', '54783', '54784']
    nosy_count = 3.0
    nosy_names = ['lemburg', 'georg.brandl', 'kxroberto']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue1472176'
    versions = []

    @kxroberto
    Copy link
    Mannequin Author

    kxroberto mannequin commented Apr 18, 2006

    httplib employs the "idna" encoding. that leads to
    errors in py2exe/cxfreeze. And if forced into the
    installer, it draws the 400kB+ unicodedata.pyd (on Win)
    in innocent small apps. Otherwise no normal technical
    modules draw the unicodedata.

    Is that really necessary?

    @kxroberto kxroberto mannequin closed this as completed Apr 18, 2006
    @kxroberto kxroberto mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Apr 18, 2006
    @kxroberto kxroberto mannequin closed this as completed Apr 18, 2006
    @kxroberto kxroberto mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Apr 18, 2006
    @malemburg
    Copy link
    Member

    Logged In: YES
    user_id=38388

    I agree - in most cases, ASCII will be used for hostnames
    (where the idna encoding is being used in httplib).

    A little helper function to first try .encode('ascii') and
    then revert to .encode('idna') would do wonders.

    Patches are welcome !

    @kxroberto
    Copy link
    Mannequin Author

    kxroberto mannequin commented Apr 19, 2006

    Logged In: YES
    user_id=972995

    a patch attached

    @birkenfeld
    Copy link
    Member

    Logged In: YES
    user_id=849994

    Slightly reformatted version of patch applied in rev. 45890.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants