Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --with-wctype-functions configure option #53456

Closed
amauryfa opened this issue Jul 9, 2010 · 5 comments
Closed

remove --with-wctype-functions configure option #53456

amauryfa opened this issue Jul 9, 2010 · 5 comments
Assignees

Comments

@amauryfa
Copy link
Member

amauryfa commented Jul 9, 2010

BPO 9210
Nosy @malemburg, @birkenfeld, @amauryfa, @ezio-melotti, @merwok
Files
  • kill-wctype.patch: don't forget to regenerate "configure"
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/amauryfa'
    closed_at = <Date 2010-09-12.22:43:35.632>
    created_at = <Date 2010-07-09.09:15:15.574>
    labels = ['expert-unicode']
    title = 'remove --with-wctype-functions configure option'
    updated_at = <Date 2010-09-12.22:43:35.630>
    user = 'https://github.com/amauryfa'

    bugs.python.org fields:

    activity = <Date 2010-09-12.22:43:35.630>
    actor = 'amaury.forgeotdarc'
    assignee = 'amaury.forgeotdarc'
    closed = True
    closed_date = <Date 2010-09-12.22:43:35.632>
    closer = 'amaury.forgeotdarc'
    components = ['Unicode']
    creation = <Date 2010-07-09.09:15:15.574>
    creator = 'amaury.forgeotdarc'
    dependencies = []
    files = ['17919']
    hgrepos = []
    issue_num = 9210
    keywords = ['patch']
    message_count = 5.0
    messages = ['109696', '109715', '109718', '116118', '116240']
    nosy_count = 5.0
    nosy_names = ['lemburg', 'georg.brandl', 'amaury.forgeotdarc', 'ezio.melotti', 'eric.araujo']
    pr_nums = []
    priority = 'critical'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue9210'
    versions = ['Python 3.2']

    @amauryfa
    Copy link
    Member Author

    amauryfa commented Jul 9, 2010

    Quoting Marc-Andre Lemburg:
    """
    The support for the wctype functions should have been remove long ago,
    since they cause subtle incompatibilities between Python builds. I should
    have probably never added it in the first place... people were worried
    about the size of the type record tables at the time, which is why
    I thought it would be a good idea to try to optionally use the C lib
    functions.

    The comment was true before the Python type tables were changed
    into a type record database: the switch used to remove the
    Python tables required for those functions. With the type records
    database, this is no longer the case, since the records are also
    being used for properties that are not exposed via wctype functions.
    """

    @amauryfa
    Copy link
    Member Author

    amauryfa commented Jul 9, 2010

    Patch attached.

    @malemburg
    Copy link
    Member

    Amaury Forgeot d'Arc wrote:

    Amaury Forgeot d'Arc <amauryfa@gmail.com> added the comment:

    Patch attached.

    Thanks. The patch looks good and I'd be +1 on applying it.

    The only problem I see is that we may have to follow the deprecation
    process.

    OTOH, I've announce the plan in 2004 and confirmed it again in 2005:

    http://mail.python.org/pipermail/python-dev/2004-December/050193.html
    http://mail.python.org/pipermail/python-dev/2005-April/052989.html

    @birkenfeld
    Copy link
    Member

    I would say, go ahead and apply for 3.2.

    @amauryfa amauryfa self-assigned this Sep 12, 2010
    @amauryfa
    Copy link
    Member Author

    Applied in r84752.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants