-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDLE: use theme colors for help viewer #78955
Comments
Follow-up to #78729. Use user-selected color theme for Help => IDLE Help. (Patch coming.) |
If HelpText is ever subclassed from a view text class, the color_config and call will be deleted. But changing the two fixed colors will be needed in any case. The background option in For the pre block, "background='#eeffcc'" gives the block a yellow background that matches the one used in online docs, as viewed by me with Firefox. So it is made conditional on the foreground color being the default solid black (which is different from tk's 'black'). Border colors appear to be fixed at some black, making the border invisible on a black or near-black background. But it does not seem worthwhile to try to decide when to omit it. |
I have tested this on Windows with both light and dark themes. |
This is working on Ubuntu. Probably not a big deal, but because the help viewer is not modal, it's possible to change the theme with the help window open and the text isn't updated on the help window. If the help is closed and reopened, then the new theme appears. |
Python docs now have a theme selector at the top center-right with options 'Auto', 'Light', and 'Dark'. Box backgrounds and borders are grayed versions of the background and foreground colors. Perhaps 15%. Code within a box is somewhat highlighted, but skip for now as would have to restrict colorizing to box content. |
…ythonGH-9502) (cherry picked from commit 7758be4) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
Linked PRs
The text was updated successfully, but these errors were encountered: