Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all abstract types have their method validated in test_collections #98513

Closed
sobolevn opened this issue Oct 21, 2022 · 1 comment
Closed

Not all abstract types have their method validated in test_collections #98513

sobolevn opened this issue Oct 21, 2022 · 1 comment
Assignees
@sobolevn
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir

Comments

@sobolevn
Copy link
Member

sobolevn commented Oct 21, 2022 •
edited by bedevere-bot

Most types with @abstractmethod definitions have their methods validated in test_collections.py, for example:

  1. https://github.com/python/cpython/blame/49f61068f49747164988ffc5a442d2a63874fc17/Lib/test/test_collections.py#L1896-L1897
  2. https://github.com/python/cpython/blame/49f61068f49747164988ffc5a442d2a63874fc17/Lib/test/test_collections.py#L928

But, not these three:

  1. Awaitable
  2. Coroutine
  3. ByteString

I will add missing test cases for it.
Related #98512
@sobolevn sobolevn added tests Tests in the Lib/test dir stdlib Python modules in the Lib dir labels Oct 21, 2022
@sobolevn sobolevn self-assigned this Oct 21, 2022
sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 21, 2022
@sobolevn
pythongh-98513: Test abstract methods of some collections types
ee1f169
@bedevere-bot bedevere-bot mentioned this issue Oct 21, 2022
Merged
JelleZijlstra pushed a commit that referenced this issue Nov 8, 2022
@sobolevn
gh-98513: Test abstract methods of some collections types (#98516)
a309ad9
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 8, 2022
@sobolevn @miss-islington
pythongh-98513: Test abstract methods of some collections types (py…
692fc5c 
…thonGH-98516)

(cherry picked from commit a309ad9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot mentioned this issue Nov 8, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 8, 2022
@sobolevn @miss-islington
pythongh-98513: Test abstract methods of some collections types (py…
16c9d92 
…thonGH-98516)

(cherry picked from commit a309ad9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot mentioned this issue Nov 8, 2022
Merged
miss-islington added a commit that referenced this issue Nov 8, 2022
@miss-islington @sobolevn
gh-98513: Test abstract methods of some collections types (GH-98516)
a5d3e1d 
(cherry picked from commit a309ad9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
JelleZijlstra pushed a commit that referenced this issue Nov 8, 2022
@miss-islington @sobolevn
[3.11] gh-98513: Test abstract methods of some collections types (G…
1add239 
…H-98516) (#99226)

(cherry picked from commit a309ad9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@hauntsaninja
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @hauntsaninja