Skip to content

gh-98513: Test abstract methods of some collections types #98516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 1 commit into from
Nov 8, 2022
Merged

gh-98513: Test abstract methods of some collections types #98516

JelleZijlstra merged 1 commit into from
Nov 8, 2022

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 21, 2022 •
edited by bedevere-bot
Loading

@sobolevn sobolevn requested a review from rhettinger as a code owner October 21, 2022 10:55
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 21, 2022
@sobolevn
Copy link
Member Author

sobolevn commented Oct 25, 2022 •
edited
Loading

CC @JelleZijlstra because this is typing related.

@JelleZijlstra JelleZijlstra self-assigned this Oct 25, 2022
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Oct 25, 2022

Will wait a while to merge in case @rhettinger has any feedback.

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 8, 2022
@JelleZijlstra JelleZijlstra merged commit a309ad9 into python:main Nov 8, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Nov 8, 2022

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 8, 2022
@sobolevn @miss-islington
pythongh-98513: Test abstract methods of some collections types (py…
692fc5c 
…thonGH-98516)

(cherry picked from commit a309ad9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

bedevere-bot commented Nov 8, 2022

GH-99226 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 8, 2022
@sobolevn @miss-islington
pythongh-98513: Test abstract methods of some collections types (py…
16c9d92 
…thonGH-98516)

(cherry picked from commit a309ad9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 8, 2022
@bedevere-bot
Copy link

bedevere-bot commented Nov 8, 2022

GH-99227 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 8, 2022
miss-islington added a commit that referenced this pull request Nov 8, 2022
@miss-islington @sobolevn
gh-98513: Test abstract methods of some collections types (GH-98516)
a5d3e1d 
(cherry picked from commit a309ad9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
JelleZijlstra pushed a commit that referenced this pull request Nov 8, 2022
@miss-islington @sobolevn
[3.11] gh-98513: Test abstract methods of some collections types (G…
1add239 
…H-98516) (#99226)

(cherry picked from commit a309ad9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

+1 more reviewer

@Cammiec91 Cammiec91 Cammiec91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @JelleZijlstra @miss-islington @bedevere-bot @Cammiec91