GH-100719: Remove the co_nplaincellvars field from code objects.
#100721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Jan 3, 2023
| @@ -9514,7 +9514,7 @@ super_init_without_args(_PyInterpreterFrame *cframe, PyCodeObject *co, | |||
|
|
|||
| // Look for __class__ in the free vars. | |||
| PyTypeObject *type = NULL; | |||
| int i = co->co_nlocals + co->co_nplaincellvars; | |||
| int i = PyCode_GetFirstFree(co); | |||
There was a problem hiding this comment.
This should be an int. I'll change PyCode_GetFirstFree.
| @@ -1119,7 +1119,7 @@ frame_init_get_vars(_PyInterpreterFrame *frame) | |||
|
|
|||
| /* Free vars have not been initialized -- Do that */ | |||
| PyObject *closure = ((PyFunctionObject *)frame->f_funcobj)->func_closure; | |||
| int offset = co->co_nlocals + co->co_nplaincellvars; | |||
| int offset = PyCode_GetFirstFree(co); | |||
| @@ -2260,7 +2260,7 @@ compiler_make_closure(struct compiler *c, location loc, | |||
| qualname = co->co_name; | |||
|
|
|||
| if (co->co_nfreevars) { | |||
| int i = co->co_nlocals + co->co_nplaincellvars; | |||
| int i = PyCode_GetFirstFree(co); | |||
iritkatriel
approved these changes
Jan 4, 2023
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a redundant field