bpo-19376: Added doc. #10243

toanant · 2018-10-30T15:20:48Z

[bpo-19376](https://bugs.python.org/issue19376): Added note mentioning `datetime.strptime()` without a year fails on Feb 29.

https://bugs.python.org/issue19376

the-knights-who-say-ni · 2018-10-30T15:20:53Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Doc/library/datetime.rst

the-knights-who-say-ni · 2018-10-31T06:55:46Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Doc/library/datetime.rst

bedevere-bot · 2018-10-31T19:11:07Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

taleinat

Looking at this again, IMO we should add two notes:

Not proving a year leads to using 1900.
Feb. 29th without a year will fail due to the above.

These should be added at the end of the "Notes" section at the end of this page. It would probably be best to make this a single note with two short sentences.

I want you to know that seeing your suggested PR has helped me realize how I think this should be done, and hope you accept my requesting multiple revisions as a necessary part of the process.

pganssle · 2018-11-05T14:27:14Z

@taleinat Generally speaking I agree that there should be two things communicated:

The default value is 1900-01-01T00:00:00.000 - any components parsed out of a string will replace the corresponding value in that datetime, and when using strftime, any components requested in the format string but missing from the object itself (in the case of datetime.date and datetime.time objects) will be pulled from the default value.
Because of point 1, parsing any string with "Feb 29" but no year will cause an error, since 1900 is not a leap year.

There are currently 2 paragraphs in the preamble covering the behavior of strftime with time and date (though they do not mention that they are specific to strftime, which makes it a bit confusing). I would propose that we cover point 1 in 2-3 paragraphs that would replace those existing paragraphs and give a more general view of "what happens when information is missing". Point 2 can be a footnote referenced in those paragraphs.

Unfortunately I don't, at the moment, have a proposed wording for this.

pganssle · 2018-11-05T14:29:29Z

Also, @toanant I would like to echo @taleinat's thanks for your patience with this. I know it can feel like reviewers are being persnickety about minor things (particularly if they disagree with one another), and I hope that we have done a good job communicating to you that your contribution to the project is valuable.

toanant · 2018-11-13T16:07:13Z

@taleinat Added Notes as suggested.

taleinat · 2018-11-13T16:26:20Z

@toanant, I agree with @pablogsal: We should first mention that the default is 1900-01-01T00:00:00.000 and all non-supplied components will fall back to those values, and then as a followup mention that that means that parsing a string with Feb 29 but no year will fail.

toanant · 2019-02-16T12:18:13Z

@pganssle Thanks for your helpful inline comments, I've applied them accordingly.
Please let me know in case any modification needed for latest patch.

Doc/library/datetime.rst

pganssle

Thanks for your patience @toanant, this looks good enough to me. Kind of hard to get this across clearly, so maybe there's a better way to do it, but I definitely think this change is a positive change.

taleinat · 2019-02-17T07:55:52Z

After further review, I suggest rewording the first paragraph to the following, which is more concise and hopefully clearer. If others approve, I will make this change and merge this PR.

For the datetime.strptime class method, the default value is 1900-01-01T00:00:00.000: any components not specified in the format string will be pulled from the default value.

Suggested ReST:
For the :meth:`datetime.strptime` class method, the default value is ``1900-01-01T00:00:00.000``: any components not specified in the format string will be pulled from the default value. [#]_

Added doc mentioning `datetime.strptime()` without a year fails for Feb 29.

toanant · 2019-02-17T18:07:35Z

@pganssle @taleinat I've incorporated changes suggested by you. Do let me know any change needed for latest patch.

csabella · 2019-05-17T23:25:40Z

@pganssle and @taleinat, please review again after the last changes by @toanant. Thanks!

pganssle

Looks good to me, sorry for the long delay in the review.

Thanks @csabella for the ping!

miss-islington · 2019-05-18T20:36:22Z

Thanks @toanant for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

…fails for Feb 29. (pythonGH-10243) (cherry picked from commit 56027cc) Co-authored-by: Abhishek Kumar Singh <toanant@users.noreply.github.com>

csabella · 2019-05-18T20:38:24Z

Thank you @toanant for the contribution and thank you @pganssle for the review and approval. Also thanks to @taleinat for the reviews. This has been merged! 🎉

miss-islington · 2019-05-18T21:32:32Z

Thanks @toanant for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · 2019-05-20T15:25:25Z

Thanks @toanant for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

vstinner · 2019-05-20T15:28:47Z

@csabella: It may be worth it to backport this doc change to 3.7, but @miss-islington looks sick :-(

… year fails for Feb 29. (pythonGH-10243) (cherry picked from commit 56027cc) Co-authored-by: Abhishek Kumar Singh <toanant@users.noreply.github.com>

bedevere-bot · 2019-05-21T18:56:01Z

GH-13470 is a backport of this pull request to the 3.7 branch.

… year fails for Feb 29. (GH-10243) (cherry picked from commit 56027cc) Co-authored-by: Abhishek Kumar Singh <toanant@users.noreply.github.com>

taleinat · 2019-05-21T19:12:46Z

@vstinner, shouldn't this also be backported to 3.6 and 2.7?

vstinner · 2019-05-21T21:34:22Z

@vstinner, shouldn't this also be backported to 3.6 and 2.7?

I became lazy and I stopped to backport doc enhancements to Python 2.7. Sorry Python 2.7 :-(

Python 3.6 no longer accept doc changes: https://devguide.python.org/#status-of-python-branches

the-knights-who-say-ni added the CLA not signed label Oct 30, 2018

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 30, 2018

pganssle requested changes Oct 30, 2018

View reviewed changes

Doc/library/datetime.rst Outdated Show resolved Hide resolved

bedevere-bot added awaiting core review and removed awaiting review labels Oct 30, 2018

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Oct 31, 2018

toanant force-pushed the patch-3 branch from 2624cd8 to 47135fc Compare October 31, 2018 06:55

the-knights-who-say-ni removed the CLA signed label Oct 31, 2018

the-knights-who-say-ni added the CLA not signed label Oct 31, 2018

toanant force-pushed the patch-3 branch from 47135fc to fa23a51 Compare October 31, 2018 07:09

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Oct 31, 2018

taleinat added the skip news label Oct 31, 2018

taleinat requested changes Oct 31, 2018

View reviewed changes

Doc/library/datetime.rst Outdated Show resolved Hide resolved

bedevere-bot removed the awaiting core review label Oct 31, 2018

bedevere-bot added the awaiting changes label Oct 31, 2018

toanant force-pushed the patch-3 branch from fa23a51 to 3c6d244 Compare November 1, 2018 05:00

taleinat requested changes Nov 5, 2018

View reviewed changes

toanant force-pushed the patch-3 branch from 3c6d244 to d9cdaa0 Compare November 13, 2018 15:41

toanant force-pushed the patch-3 branch 2 times, most recently from 2d527a4 to 02faf30 Compare November 13, 2018 16:54

pganssle reviewed Feb 16, 2019

View reviewed changes

Doc/library/datetime.rst Outdated Show resolved Hide resolved

toanant force-pushed the patch-3 branch from 02636c2 to 3aca80f Compare February 16, 2019 16:15

pganssle approved these changes Feb 17, 2019

View reviewed changes

bpo-19376: Added doc.

941b8cc

Added doc mentioning `datetime.strptime()` without a year fails for Feb 29.

toanant force-pushed the patch-3 branch from 3aca80f to 941b8cc Compare February 17, 2019 16:15

csabella requested a review from taleinat May 17, 2019 23:24

pganssle approved these changes May 18, 2019

View reviewed changes

csabella added the needs backport to 3.7 label May 18, 2019

csabella merged commit 56027cc into python:master May 18, 2019

bedevere-bot removed the awaiting changes label May 18, 2019

csabella added needs backport to 3.7 and removed needs backport to 3.7 labels May 18, 2019

vstinner added needs backport to 3.7 and removed needs backport to 3.7 labels May 20, 2019

bedevere-bot removed the needs backport to 3.7 label May 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-19376: Added doc. #10243

bpo-19376: Added doc. #10243

toanant commented Oct 30, 2018 •

edited by bedevere-bot

Loading

the-knights-who-say-ni commented Oct 30, 2018

the-knights-who-say-ni commented Oct 31, 2018

bedevere-bot commented Oct 31, 2018

taleinat left a comment •

edited

Loading

pganssle commented Nov 5, 2018

pganssle commented Nov 5, 2018

toanant commented Nov 13, 2018

taleinat commented Nov 13, 2018

toanant commented Feb 16, 2019

pganssle left a comment

taleinat commented Feb 17, 2019

toanant commented Feb 17, 2019

csabella commented May 17, 2019

pganssle left a comment •

edited

Loading

miss-islington commented May 18, 2019

csabella commented May 18, 2019

miss-islington commented May 18, 2019

miss-islington commented May 20, 2019

vstinner commented May 20, 2019

bedevere-bot commented May 21, 2019

taleinat commented May 21, 2019

vstinner commented May 21, 2019

bpo-19376: Added doc. #10243

bpo-19376: Added doc. #10243

Conversation

toanant commented Oct 30, 2018 • edited by bedevere-bot Loading

the-knights-who-say-ni commented Oct 30, 2018

the-knights-who-say-ni commented Oct 31, 2018

bedevere-bot commented Oct 31, 2018

taleinat left a comment • edited Loading

Choose a reason for hiding this comment

pganssle commented Nov 5, 2018

pganssle commented Nov 5, 2018

toanant commented Nov 13, 2018

taleinat commented Nov 13, 2018

toanant commented Feb 16, 2019

pganssle left a comment

Choose a reason for hiding this comment

taleinat commented Feb 17, 2019

toanant commented Feb 17, 2019

csabella commented May 17, 2019

pganssle left a comment • edited Loading

Choose a reason for hiding this comment

miss-islington commented May 18, 2019

csabella commented May 18, 2019

miss-islington commented May 18, 2019

miss-islington commented May 20, 2019

vstinner commented May 20, 2019

bedevere-bot commented May 21, 2019

taleinat commented May 21, 2019

vstinner commented May 21, 2019

toanant commented Oct 30, 2018 •

edited by bedevere-bot

Loading

taleinat left a comment •

edited

Loading

pganssle left a comment •

edited

Loading