Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-99944: Make dis display the value of oparg of KW_NAMES #103856

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

jkchandalia
Copy link
Contributor

@jkchandalia jkchandalia commented Apr 25, 2023

Make the dis module display the value of the oparg of KW_NAMES.

Co-authored-by: chilaxan chilaxan@gmail.com

Fixes #99944

chilaxan and others added 3 commits April 25, 2023 13:27
3.11 adds a new opcode KW_NAMES that has an entry in co_consts, however the hardcoded check here causes dis to not grab the constant
@jkchandalia
Copy link
Contributor Author

FYI @iritkatriel

Lib/test/test_dis.py Outdated Show resolved Hide resolved
@iritkatriel iritkatriel changed the title GH-99944: Add test to verify dis output contains information for KW_NAMES GH-99944: Make dis display the value of oparg of KW_NAMES Apr 25, 2023
@iritkatriel iritkatriel added type-feature A feature request or enhancement stdlib Python modules in the Lib dir labels Apr 25, 2023
@iritkatriel iritkatriel merged commit d45225b into python:main Apr 26, 2023
20 checks passed
@jkchandalia
Copy link
Contributor Author

FYI @nanjekyejoannah

itamaro pushed a commit to itamaro/cpython that referenced this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dis output is missing information for KW_NAMES
4 participants