Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dis output is missing information for KW_NAMES #99944

Closed
chilaxan opened this issue Dec 2, 2022 · 3 comments · Fixed by #103856
Closed

dis output is missing information for KW_NAMES #99944

chilaxan opened this issue Dec 2, 2022 · 3 comments · Fixed by #103856
Labels
type-bug An unexpected behavior, bug, or error

Comments

@chilaxan
Copy link
Contributor

chilaxan commented Dec 2, 2022 •
edited by bedevere-bot

Bug report

dis output is missing the constant value for KW_NAMES

This is due to a hardcoded check that the op is LOAD_CONST before grabbing the value.
This check comes after a check that the opcode is in dis.hasconst, so reasonably it can be removed to allow KW_NAMES and future opcodes that feature constants to work moving forward.

I have drafted a simple pull request #99943 to fix this bug

Linked PRs
@chilaxan chilaxan added the type-bug An unexpected behavior, bug, or error label Dec 2, 2022
@bedevere-bot bedevere-bot mentioned this issue Dec 4, 2022
Closed
@Sarenard
Copy link

It seems that i have the same problem, is this pr still active?

@arhadthedev
Copy link
Member

@Lorisredstone The PR needs tests and there is nobody with free time to dig into the matter and add them.

@jkchandalia jkchandalia mentioned this issue Apr 25, 2023
Merged
iritkatriel pushed a commit that referenced this issue Apr 26, 2023
@jkchandalia @chilaxan
GH-99944: Make dis display the value of oparg of KW_NAMES (#103856)
d45225b 
Co-authored-by: chilaxan <chilaxan@gmail.com>
@iritkatriel
Copy link
Member

Thank you @chilaxan and @jkchandalia.

itamaro pushed a commit to itamaro/cpython that referenced this issue Apr 26, 2023
@jkchandalia @chilaxan @itamaro
pythonGH-99944: Make dis display the value of oparg of KW_NAMES (pyth…
0392292 
…on#103856)

Co-authored-by: chilaxan <chilaxan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-99944: Make dis display the value of oparg of KW_NAMES jkchandalia/cpython
4 participants
@iritkatriel @arhadthedev @chilaxan @Sarenard