Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-64658: Expand Argument Clinic return converter docs #104175

Merged
merged 7 commits into from
May 5, 2023
Merged

gh-64658: Expand Argument Clinic return converter docs #104175

merged 7 commits into from
May 5, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 4, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 4, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels May 4, 2023
@erlend-aasland erlend-aasland linked an issue May 4, 2023 that may be closed by this pull request
[doc] No Argument Clinic documentation on how to specify a return converter #64658
Closed
AlexWaygood
AlexWaygood reviewed May 4, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only understand AC in the vaguest terms, but that is definitely a sentence that makes grammatical sense! :)

@erlend-aasland

This comment was marked as outdated.

Sign in to view
@erlend-aasland erlend-aasland changed the title gh-64658: Amend Argument Clinic return converter docs gh-64658: Expand Argument Clinic return converter docs May 4, 2023
@erlend-aasland
Copy link
Contributor Author

BTW, I removed the reference to the init converter; it's only used internally by AC anyways.

@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label May 5, 2023
@erlend-aasland
Copy link
Contributor Author

FTR, I'm landing this soon. We can easily fix nitpicks in the docs later (no issue needed).

AlexWaygood
AlexWaygood reviewed May 5, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, but I still feel like a very underqualified reviewer here :)

Doc/howto/clinic.rst Outdated Show resolved Hide resolved
@erlend-aasland @AlexWaygood
Update Doc/howto/clinic.rst
88ed3c1 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
erlend-aasland
erlend-aasland commented May 5, 2023
View reviewed changes
Doc/howto/clinic.rst Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland merged commit 721a783 into python:main May 5, 2023
12 checks passed
@erlend-aasland erlend-aasland deleted the clinic-doc-ret-conv branch May 5, 2023 11:32
@erlend-aasland erlend-aasland removed the needs backport to 3.11 only security fixes label May 5, 2023
@bedevere-bot
Copy link

GH-104198 is a backport of this pull request to the 3.11 branch.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 5, 2023
@erlend-aasland
[3.11] pythongh-64658: Expand Argument Clinic return converter docs (p…
ea0eac3 
…ython#104175)
erlend-aasland added a commit that referenced this pull request May 5, 2023
@erlend-aasland
[3.11] gh-64658: Expand Argument Clinic return converter docs (#104175)…
a635d63 
… (#104198)
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
jbower-fb pushed a commit to jbower-fb/cpython-jbowerfb that referenced this pull request May 8, 2023
@erlend-aasland @jbower-fb
pythongh-64658: Expand Argument Clinic return converter docs (python#…
be60d71 
…104175)
erlend-aasland added a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
@erlend-aasland
python/cpython#64658: Expand Argument Clinic return converter docs (p…
3edac31 
…ython/cpython#104175)
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
@erlend-aasland
python/cpython#64658: Expand Argument Clinic return converter docs (p…
59eef01 
…ython/cpython#104175)
erlend-aasland added a commit to python/devguide that referenced this pull request Sep 26, 2023
@erlend-aasland
python/cpython#64658: Expand Argument Clinic return converter docs (p…
769053f 
…ython/cpython#104175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc] No Argument Clinic documentation on how to specify a return converter
3 participants
@erlend-aasland @bedevere-bot @AlexWaygood