Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104190: fix ubsan crash #104191

Merged
merged 1 commit into from
May 5, 2023
Merged

gh-104190: fix ubsan crash #104191

merged 1 commit into from
May 5, 2023

Conversation

sunmy2019
Copy link
Member

@sunmy2019 sunmy2019 commented May 5, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
Closed
@gaogaotiantian gaogaotiantian added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section type-crash A hard crash of the interpreter, possibly with a core dump labels May 5, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gaogaotiantian for commit c634b91 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2023
@gaogaotiantian
Copy link
Member

Good catch! It seems to me that ObjExtraData_Type is a bad name here - super confusing with all the other similar names being the PyTypeObject instead of the pointer. Maybe we should consider renaming the variable.

@sunmy2019
Copy link
Member Author

Maybe we should consider renaming the variable.

It makes sense in some respects. But a quick search in the code base, most variable names receiving PyType_FromModuleAndSpec has patterns

xxx_xxx_type (count=30)
XxxXxx_Type (count=15)
XxxXxxType (count=6)

No strong preference was found. I am OK either way.

@kumaraditya303 kumaraditya303 merged commit 1630345 into python:main May 5, 2023
19 checks passed
@brandtbucher brandtbucher mentioned this pull request May 5, 2023
Merged
@Fidget-Spinner
Copy link
Member

@sunmy2019 sorry for hijacking this issue, but could you please email me at kenjin@python.org to discuss potential triage permissions?

carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
jbower-fb pushed a commit to jbower-fb/cpython-jbowerfb that referenced this pull request May 8, 2023
@sunmy2019 @jbower-fb
pythongh-104190: fix ubsan crash (python#104191)
3205457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sunmy2019 @bedevere-bot @gaogaotiantian @Fidget-Spinner @kumaraditya303