gh-75367: fix data descriptor detection in inspect.getattr_static #104517

furkanonder · 2023-05-15T23:50:17Z

Issue: Fix data descriptor detection in inspect.getattr_static #75367

carljm

Thanks for the PR!

Code change LGTM. Test can be simplified, I think. Please add NEWS entry.

Lib/test/test_inspect.py

Co-authored-by: Carl Meyer <carl@oddbird.net>

furkanonder · 2023-05-16T13:17:14Z

Thanks for the PR!

Code change LGTM. Test can be simplified, I think. Please add NEWS entry.

Thanks!

AlexWaygood

Thanks @furkanonder!

miss-islington · 2023-05-16T17:34:48Z

Thanks @furkanonder for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot · 2023-05-16T17:35:00Z

GH-104557 is a backport of this pull request to the 3.11 branch.

…ic (pythonGH-104517) (cherry picked from commit 5e9f471) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Carl Meyer <carl@oddbird.net>

bedevere-bot · 2023-05-16T17:52:19Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit 5e9f471.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/464/builds/4472) and take a look at the build logs.
Check if the failure is related to this commit (5e9f471) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/464/builds/4472

Failed tests:

test.test_asyncio.test_subprocess

Failed subtests:

test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

446 tests OK.

1 test failed:
test.test_asyncio.test_subprocess

18 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_asdl_parser test_clinic
test_devpoll test_gdb test_ioctl test_kqueue test_launcher
test_msilib test_peg_generator test_perf_profiler test_startfile
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

2 re-run tests:
test.test_asyncio.test_subprocess test_threading

Total duration: 9 min 22 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/test/test_asyncio/test_subprocess.py", line 788, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/test/test_asyncio/test_subprocess.py", line 780, in main
    self.assertEqual(events, [
AssertionError: Lists differ: [('pi[29 chars]t'), 'pipe_connection_lost', ('pipe_data_recei[57 chars]ted'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/test/test_asyncio/test_subprocess.py", line 788, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.12/test/test_asyncio/test_subprocess.py", line 780, in main
    self.assertEqual(events, [
AssertionError: Lists differ: [('pi[69 chars]), 'process_exited', 'pipe_connection_lost', '[17 chars]ost'] != [('pi[69 chars]), 'pipe_connection_lost', 'pipe_connection_lo[17 chars]ted']

…tic (GH-104517) (#104557) gh-75367: Fix data descriptor detection in inspect.getattr_static (GH-104517) (cherry picked from commit 5e9f471) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Carl Meyer <carl@oddbird.net>

bedevere-bot · 2023-05-16T18:03:29Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit 5e9f471.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/58/builds/4570) and take a look at the build logs.
Check if the failure is related to this commit (5e9f471) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/58/builds/4570

Failed tests:

test.test_asyncio.test_subprocess

Failed subtests:

test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

448 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 7 sec
test_multiprocessing_spawn: 1 min 26 sec
test_multiprocessing_forkserver: 1 min 10 sec
test_signal: 1 min 9 sec
test_multiprocessing_fork: 1 min 5 sec
test_hashlib: 38.1 sec
test_io: 33.1 sec
test_socket: 30.8 sec
test_imaplib: 30.5 sec
test_xmlrpc: 27.3 sec

1 test failed:
test.test_asyncio.test_subprocess

16 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_ioctl test_kqueue test_launcher test_msilib
test_peg_generator test_perf_profiler test_startfile
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

2 re-run tests:
test.test_asyncio.test_subprocess test_threading

Total duration: 9 min 52 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_subprocess.py", line 788, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_subprocess.py", line 780, in main
    self.assertEqual(events, [
AssertionError: Lists differ: [('pi[29 chars]t'), 'pipe_connection_lost', ('pipe_data_recei[57 chars]ted'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']

* main: (26 commits) pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508) typing: Add more tests for TypeVar (python#104571) pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573) typing: Use PEP 695 syntax in typing.py (python#104553) pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508) pythongh-104469: Update README.txt for _testcapi (pythongh-104529) pythonGH-103092: isolate `_elementtree` (python#104561) pythongh-104050: Add typing to Argument Clinic converters (python#104547) pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909) pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351) pythonGH-103092: isolate `pyexpat` (python#104506) pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517) pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544) pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556) pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866) CODEOWNERS: Assign new PEP 695 files to myself (python#104551) pythonGH-104510: Fix refleaks in `_io` base types (python#104516) pythongh-104539: Fix indentation error in logging.config.rst (python#104545) pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543) pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) ...

fix data descriptor detection in inspect.getattr_static

67912be

bedevere-bot added the awaiting review label May 15, 2023

bedevere-bot mentioned this pull request May 15, 2023

Fix data descriptor detection in inspect.getattr_static #75367

Closed

carljm reviewed May 16, 2023

View reviewed changes

Lib/test/test_inspect.py Outdated Show resolved Hide resolved

furkanonder and others added 3 commits May 16, 2023 13:41

Update Lib/test/test_inspect.py

de2a892

Co-authored-by: Carl Meyer <carl@oddbird.net>

Merge branch 'main' into pythongh-75367

f758dcd

📜🤖 Added by blurb_it.

ccb7fe7

carljm approved these changes May 16, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels May 16, 2023

furkanonder and others added 2 commits May 16, 2023 13:17

Merge branch 'main' into pythongh-75367

de48adc

Fix sphinx role

4df0469

AlexWaygood approved these changes May 16, 2023

View reviewed changes

AlexWaygood enabled auto-merge (squash) May 16, 2023 17:03

AlexWaygood added the needs backport to 3.11 only security fixes label May 16, 2023

AlexWaygood merged commit 5e9f471 into python:main May 16, 2023
21 of 22 checks passed

bedevere-bot removed the awaiting merge label May 16, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label May 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-75367: fix data descriptor detection in inspect.getattr_static #104517

gh-75367: fix data descriptor detection in inspect.getattr_static #104517

furkanonder commented May 15, 2023 •

edited by bedevere-bot

carljm left a comment

furkanonder commented May 16, 2023

AlexWaygood left a comment

miss-islington commented May 16, 2023

bedevere-bot commented May 16, 2023

bedevere-bot commented May 16, 2023

bedevere-bot commented May 16, 2023

gh-75367: fix data descriptor detection in inspect.getattr_static #104517

gh-75367: fix data descriptor detection in inspect.getattr_static #104517

Conversation

furkanonder commented May 15, 2023 • edited by bedevere-bot

carljm left a comment

Choose a reason for hiding this comment

furkanonder commented May 16, 2023

AlexWaygood left a comment

Choose a reason for hiding this comment

miss-islington commented May 16, 2023

bedevere-bot commented May 16, 2023

bedevere-bot commented May 16, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented May 16, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

furkanonder commented May 15, 2023 •

edited by bedevere-bot