gh-104050: Add basic typing to CConverter in clinic.py

[erlend-aasland]

• Issue: Add type annotations to clinic.py #104050

[AlexWaygood]

Doesn't need to be done now (and you may not like the suggestion), but you could use an enum for all the sentinels that are defined in clinic.py, instead of defining three separate classes (Unspecified, Null and Unknown):

import enum
from typing import Final

class Sentinels(enum.Enum):
    unspecified = 'Unspecified'
    NULL = 'Null'
    unknown = 'Unknown'

    def __repr__(self):
        return f'<{self.value}>'


unspecified: Final = Sentinels.unspecified
NULL: Final = Sentinels.NULL
unknown: Final = Sentinels.unknown

If you did that, then you'd be able to use a typing.Literal annotation here, which would be more expressive of the fact that unspecified is a singleton:

Suggested change

	annotation: str | Unspecified = unspecified,
	annotation: str | Literal[Sentinels.unspecified] = unspecified,

[erlend-aasland]

Neat!

[erlend-aasland]

This looks fishy. parameter should be a Parameter instance, but also str is accepted. Let's look into that in a follow-up PR.