Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-32153: Add unit test for create_autospec with partial function returned in getattr (GH-10398) #10855

Merged
merged 1 commit into from Dec 3, 2018

Conversation

@miss-islington
Copy link

miss-islington commented Dec 3, 2018

  • Add create_autospec with partial function returned in getattr

  • Use self.assertFalse instead of assert

  • Use different names and remove object
    (cherry picked from commit c667b09)

Co-authored-by: Xtreak tirkarthi@users.noreply.github.com

https://bugs.python.org/issue32153

…turned in getattr (GH-10398)

* Add create_autospec with partial function returned in getattr

* Use self.assertFalse instead of assert

* Use different names and remove object
(cherry picked from commit c667b09)

Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Dec 3, 2018

@tirkarthi and @cjw296: Status check is done, and it's a success .

@cjw296 cjw296 merged commit 1ef06c6 into python:3.7 Dec 3, 2018
6 checks passed
6 checks passed
Azure Pipelines PR #20181203.5 succeeded
Details
bedevere/issue-number Issue number 32153 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Dec 3, 2018

@cjw296: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the miss-islington:backport-c667b09-3.7 branch Dec 3, 2018
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented Dec 3, 2018

@tirkarthi and @cjw296: Status check is done, and it's a success .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.