Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] gh-110088, gh-109878: Fix test_asyncio timeouts (#110092) #110098

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[3.12] gh-110088, gh-109878: Fix test_asyncio timeouts (#110092) #110098

merged 1 commit into from
Oct 2, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 29, 2023 •
edited by bedevere-app bot

Fix test_asyncio timeouts: don't measure the maximum duration, a test should not measure a CI performance. Only measure the minimum duration when a task has a timeout or delay. Add CLOCK_RES to test_asyncio.utils.

(cherry picked from commit db0a258)

This was referenced Sep 29, 2023
Closed
Merged
willingc
willingc approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be a nice clean-up and healthy improvement for asyncio tests. +1 from me. Thanks @vstinner

@vstinner
pythongh-110088, pythongh-109878: Fix test_asyncio timeouts (python#1…
7a21cb1 
…10092)

Fix test_asyncio timeouts: don't measure the maximum duration, a test
should not measure a CI performance. Only measure the minimum
duration when a task has a timeout or delay. Add CLOCK_RES to
test_asyncio.utils.

(cherry picked from commit db0a258)
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2023

PR rebased on 3.12 to fix a merge conflict with merged commit 150bd30.

@vstinner vstinner enabled auto-merge (squash) October 2, 2023 17:22
@vstinner vstinner merged commit 0745ab8 into python:3.12 Oct 2, 2023
24 checks passed
@vstinner vstinner deleted the asyncio_timeout12 branch October 2, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vstinner @willingc