Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_asyncio.test_windows_events: test_wait_for_handle() failed on GHA Windows x86 #110088

Closed
vstinner opened this issue Sep 29, 2023 · 3 comments
Closed

test_asyncio.test_windows_events: test_wait_for_handle() failed on GHA Windows x86 #110088

vstinner opened this issue Sep 29, 2023 · 3 comments
Labels
OS-windows tests Tests in the Lib/test dir topic-asyncio

Comments

@vstinner
Copy link
Member

vstinner commented Sep 29, 2023 •
edited by bedevere-app bot

The test must not measure the performance of the CI.

GHA Windows x86:

FAIL: test_wait_for_handle (test.test_asyncio.test_windows_events.ProactorTests.test_wait_for_handle)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_asyncio\test_windows_events.py", line 188, in test_wait_for_handle
    self.assertTrue(0 <= elapsed < 0.3, elapsed)
AssertionError: False is not true : 0.3129999999998745

build: https://github.com/python/cpython/actions/runs/6348560548/job/17245417314?pr=110080

Linked PRs
@vstinner vstinner added tests Tests in the Lib/test dir topic-asyncio labels Sep 29, 2023
@vstinner vstinner mentioned this issue Sep 29, 2023
Merged
@vstinner
Copy link
Member Author

On GHA Windows x64, on another PR: https://github.com/python/cpython/actions/runs/6348572958/job/17246410556?pr=110078


FAIL: test_wait_for_handle (test.test_asyncio.test_windows_events.ProactorTests.test_wait_for_handle)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_asyncio\test_windows_events.py", line 175, in test_wait_for_handle
    self.assertTrue(0.45 <= elapsed <= 0.9, elapsed)
AssertionError: False is not true : 0.9380000000001019

@vstinner vstinner mentioned this issue Sep 29, 2023
Merged
@vstinner
Copy link
Member Author

See also issue gh-109878.

@vstinner vstinner mentioned this issue Sep 29, 2023
Closed
@zooba
Copy link
Member

zooba commented Sep 29, 2023

The test must not measure the performance of the CI.

This belongs in a Zen of Testing 😄

vstinner added a commit to vstinner/cpython that referenced this issue Sep 29, 2023
@vstinner
pythongh-110088, pythongh-109878: Fix test_asyncio timeout
24e9f0e 
Don't measure CI performance: don't measure maximum duration. Only
measure the minimum duration when a task has a timeout or delay.

Add CLOCK_RES to test_asyncio.utils.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 29, 2023
@vstinner
pythongh-110088, pythongh-109878: Fix test_asyncio timeout
9b33965 
Fix test_asyncio timeout: don't measure the maximum duration, a test
should not measure a CI performance. Only measure the minimum
duration when a task has a timeout or delay. Add CLOCK_RES to
test_asyncio.utils.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 29, 2023
@vstinner
pythongh-110088, pythongh-109878: Fix test_asyncio timeouts
9f503f9 
Fix test_asyncio timeouts: don't measure the maximum duration, a test
should not measure a CI performance. Only measure the minimum
duration when a task has a timeout or delay. Add CLOCK_RES to
test_asyncio.utils.
@bedevere-app bedevere-app bot mentioned this issue Sep 29, 2023
Merged
vstinner added a commit that referenced this issue Sep 29, 2023
@vstinner
gh-110088, gh-109878: Fix test_asyncio timeouts (#110092)
db0a258 
Fix test_asyncio timeouts: don't measure the maximum duration, a test
should not measure a CI performance. Only measure the minimum
duration when a task has a timeout or delay. Add CLOCK_RES to
test_asyncio.utils.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 29, 2023
@vstinner
pythongh-110088, pythongh-109878: Fix test_asyncio timeouts (python#1…
e4dc122 
…10092)

Fix test_asyncio timeouts: don't measure the maximum duration, a test
should not measure a CI performance. Only measure the minimum
duration when a task has a timeout or delay. Add CLOCK_RES to
test_asyncio.utils.

(cherry picked from commit db0a258)
This was referenced Sep 29, 2023
Merged
Merged
vstinner added a commit that referenced this issue Sep 29, 2023
@vstinner
[3.11] gh-110088, gh-109878: Fix test_asyncio timeouts (#110092) (#11…
184ce14 
…0099)

gh-110088, gh-109878: Fix test_asyncio timeouts (#110092)

Fix test_asyncio timeouts: don't measure the maximum duration, a test
should not measure a CI performance. Only measure the minimum
duration when a task has a timeout or delay. Add CLOCK_RES to
test_asyncio.utils.

(cherry picked from commit db0a258)
vstinner added a commit to vstinner/cpython that referenced this issue Sep 30, 2023
@vstinner
pythongh-110088: Fix asyncio test_prompt_cancellation()
e74fa4e 
Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
@bedevere-app bedevere-app bot mentioned this issue Sep 30, 2023
Merged
vstinner added a commit that referenced this issue Sep 30, 2023
@vstinner
gh-110088: Fix asyncio test_prompt_cancellation() (#110157)
c62b49e 
Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 30, 2023
@vstinner @miss-islington
pythongh-110088: Fix asyncio test_prompt_cancellation() (pythonGH-110157
6c9a357 
)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
This was referenced Sep 30, 2023
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 30, 2023
@vstinner @miss-islington
pythongh-110088: Fix asyncio test_prompt_cancellation() (pythonGH-110157
39d2f9c 
)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this issue Sep 30, 2023
@miss-islington @vstinner
[3.11] gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157) (#…
446c81c 
…110159)

gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
Yhg1s pushed a commit that referenced this issue Oct 2, 2023
@miss-islington @vstinner
[3.12] gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157) (#…
ce332aa 
…110158)

gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit to vstinner/cpython that referenced this issue Oct 2, 2023
@vstinner
pythongh-110088, pythongh-109878: Fix test_asyncio timeouts (python#1…
7a21cb1 
…10092)

Fix test_asyncio timeouts: don't measure the maximum duration, a test
should not measure a CI performance. Only measure the minimum
duration when a task has a timeout or delay. Add CLOCK_RES to
test_asyncio.utils.

(cherry picked from commit db0a258)
vstinner added a commit that referenced this issue Oct 2, 2023
@vstinner
[3.12] gh-110088, gh-109878: Fix test_asyncio timeouts (#110092) (#11…
0745ab8 
…0098)

gh-110088, gh-109878: Fix test_asyncio timeouts (#110092)

Fix test_asyncio timeouts: don't measure the maximum duration, a test
should not measure a CI performance. Only measure the minimum
duration when a task has a timeout or delay. Add CLOCK_RES to
test_asyncio.utils.

(cherry picked from commit db0a258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-windows tests Tests in the Lib/test dir topic-asyncio
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @zooba @AlexWaygood