Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157) #110158

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[3.12] gh-110088: Fix asyncio test_prompt_cancellation() (GH-110157) #110158

merged 1 commit into from
Oct 2, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 30, 2023 •
edited by bedevere-app bot

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner vstinner@python.org

@vstinner @miss-islington
pythongh-110088: Fix asyncio test_prompt_cancellation() (pythonGH-110157
6c9a357 
)

Don't measure the CI performance: don't test the maximum elapsed
time. The check failed on a slow CI.
(cherry picked from commit c62b49e)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 30, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 30, 2023
Closed
@bedevere-app bedevere-app bot mentioned this pull request Sep 30, 2023
Merged
vstinner
vstinner approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

willingc
willingc approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yhg1s Yhg1s merged commit ce332aa into python:3.12 Oct 2, 2023
27 checks passed
@miss-islington miss-islington deleted the backport-c62b49e-3.12 branch October 2, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@willingc willingc willingc approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miss-islington @vstinner @willingc @Yhg1s