Add example to the documentation for calling unittest.mock.patch with create=True #11056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
set_example_on_exists
branch
from
88e5dd0
to
8006f3c
Compare
pablogsal
force-pushed
the
set_example_on_exists
branch
from
8006f3c
to
b8dc239
Compare
|
CC: @mariocj89 |
mariocj89
approved these changes
Dec 9, 2018
pganssle
approved these changes
Jan 2, 2019
|
No problems with the English. |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11484 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 9, 2019
… create=True (pythonGH-11056) (cherry picked from commit d6acf17) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are confused with the description of
create=Truein theunittest.mockdocumentation, especially if they don't exactly understand entirely howpatchworks or if they have never tried to patch a non-existing attribute.This PR clarifies a bit the documentation and sets an example on when is needed at the end of the section.