gh-76785: Add an Internal ExceptionSnapshot Type #111572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
crossinterp-utils-exc-snapshot
branch
2 times, most recently
from
19bd5fc
to
b8ea359
Compare
iritkatriel
reviewed
Nov 2, 2023
| exctype = PyExc_RuntimeError; | ||
| } | ||
|
|
||
| _Py_excinfo_Apply(&self->info, exctype); |
There was a problem hiding this comment.
Where is this function defined?
There was a problem hiding this comment.
In Python/errors.c.
There was a problem hiding this comment.
Ah I see, I needed to refresh my branch.
This looks like a DIY serialisation of exceptions. Does it work for all exception types? What if the args to the exception constructor are not just the msg string?
ericsnowcurrently
force-pushed
the
crossinterp-utils-exc-snapshot
branch
from
b8ea359
to
29affcd
Compare
ericsnowcurrently
added a commit
that referenced
this pull request
Nov 6, 2023
…1715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in gh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see gh-111572/gh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with gh-111572, which I may, in turn, combine with gh-111573. We'll see.)
…l C-API (pythongh-111715)" This reverts commit d4426e8.
ericsnowcurrently
force-pushed
the
crossinterp-utils-exc-snapshot
branch
from
29affcd
to
b9f7974
Compare
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Nov 8, 2023
…ythongh-111715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573. We'll see.)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ythongh-111715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573. We'll see.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by _xxsubinterpretersmodule.c in a follow-up PR, though it should have utility on its own.