gh-76785: Return an "excinfo" Object From Interpreter.run() #111573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericsnowcurrently
commented
Oct 31, 2023
•
ericsnowcurrently
commented
- Issue: [subinterpreters] PEP 554 implementation: add interpreters module #76785
ericsnowcurrently
changed the title
ericsnowcurrently
force-pushed
the
interp-run-return-exc-info
branch
4 times, most recently
from
5443e2c
to
3f56dbf
Compare
ericsnowcurrently
force-pushed
the
interp-run-return-exc-info
branch
from
3f56dbf
to
f25d3f9
Compare
ericsnowcurrently
added a commit
that referenced
this pull request
Nov 6, 2023
…1715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in gh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see gh-111572/gh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with gh-111572, which I may, in turn, combine with gh-111573. We'll see.)
ericsnowcurrently
force-pushed
the
interp-run-return-exc-info
branch
from
f25d3f9
to
9f83af7
Compare
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Nov 8, 2023
…ythongh-111715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573. We'll see.)
ericsnowcurrently
force-pushed
the
interp-run-return-exc-info
branch
from
9f83af7
to
dfff3e3
Compare
ericsnowcurrently
changed the title
ericsnowcurrently
requested review from
brettcannon,
ncoghlan and
warsaw
as code owners
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ythongh-111715) I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9). Since then I've had a nagging sense that I should have added the type and functions in its own PR. While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR. Hence, here we are. (FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573. We'll see.)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.