bpo-35716: CLOCK_MONOTONIC_RAW available on macOS #11517
Conversation
Doc/library/time.rst
Outdated
| @@ -772,7 +772,7 @@ These constants are used as parameters for :func:`clock_getres` and | |||
| Similar to :data:`CLOCK_MONOTONIC`, but provides access to a raw | |||
| hardware-based time that is not subject to NTP adjustments. | |||
|
|
|||
| Availability: Linux 2.6.28 or later. | |||
| Availability: Availability: Linux 2.6.28 or later, macOS 10.12 and newer. | |||
There was a problem hiding this comment.
"Availability: Availability:" hum, it's written twice :-) While we are here, a new ".. availability::" markup has been added recently.
Can you please replace "Availability:" with ".. availability::"?
I'm not a native english speaker. What's the best: " or later" or " and newer"? os.rst uses "or newer" 3 times, but "and later" is not used. Maybe replace also "Linux 2.6.28 or later" with "Linux 2.6.28 and newer". Ah, os.rst uses "or newer" and "and newer" :-)
-- Victor the nitpicker
There was a problem hiding this comment.
Can you please replace "Availability:" with ".. availability::"?
All "Availability:" in this file, not only this one, please ;-)
There was a problem hiding this comment.
@vstinner I have seen the use of both "or newer" and "and newer" in the docs. Is this based on semantics or it is just based on preference?
|
Thanks @nanjekyejoannah for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11518 is a backport of this pull request to the 3.7 branch. |
Document that the time.CLOCK_MONOTONIC_RAW constant is now also available on macOS 10.12. Co-authored-by: Ricardo Fraile <rfraile@rfraile.eu> (cherry picked from commit fd7d539) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
Document that the time.CLOCK_MONOTONIC_RAW constant is now also available on macOS 10.12. Co-authored-by: Ricardo Fraile <rfraile@rfraile.eu> (cherry picked from commit fd7d539) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
Add macOS among supported versions for the CLOCK_MONOTONIC_RAW identifier in the description because it is already available since 10.12.
Co-authored-by: Ricardo Fraile rfraile@rfraile.eu
https://bugs.python.org/issue35716