-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-71052: Enable test_concurrent_futures on platforms that support threading but not multiprocessing #115917
Conversation
…t not multiprocessing
@gpshead: I think CODEOWNERS should probably have matched you for this PR. |
Sorry, @mhsmith and @gpshead, I could not cleanly backport this to
|
not worried about backporting, for primarily test only cleanup changes if they backport smoothly it is a mere convenience. |
|
|
... whoops, looks like CI wasn't enough here. buildbots show issues that look related. :) WASM doesn't have threading, the previously logic presumably properly skipped the test there. |
Sorry about that, and thanks for sorting it out. |
… multiprocessing (pythongh-115917) Enable test_concurrent_futures on platforms that support threading but not multiprocessing.
…115923) Fix the WASI test_concurrent_futures regression from python#115917.
… multiprocessing (pythongh-115917) Enable test_concurrent_futures on platforms that support threading but not multiprocessing.
…115923) Fix the WASI test_concurrent_futures regression from python#115917.
… multiprocessing (pythongh-115917) Enable test_concurrent_futures on platforms that support threading but not multiprocessing.
…115923) Fix the WASI test_concurrent_futures regression from python#115917.
test_concurrent_futures
was previously skipped on platforms that don't support multiprocessing. Android and iOS don't support multiprocessing, but they do support threading, so this PR gives them test coverage of the threading-related parts ofconcurrent.futures
. A couple of more focused skips were added to exclude the process-related tests.I also had to remove an unused import of
_multiprocessing
frommultiprocessing.queues
. This allowsmultiprocessing.queues
to be imported on platforms that don't support multiprocessing, as long as the code doesn't actually create a queue.Other places which are helped by this change include:
test___all__
, which no longer needs a multiprocessing-specific workaround.logging.config
, which importsmultiprocessing.queue
only to do anisinstance
check. No code changes were required here.