-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-116682: stdout may be empty in test_cancel_futures_wait_false #116683
gh-116682: stdout may be empty in test_cancel_futures_wait_false #116683
Conversation
If the shutdown() call happens before the worker thread starts executing the task then nothing will be printed to stdout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pragmatic solution is ok for a flaky test like this.
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
pythonGH-116683) If the `shutdown()` call happens before the worker thread starts executing the task, then nothing will be printed to stdout. (cherry picked from commit 7d1abe9) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-116692 is a backport of this pull request to the 3.12 branch. |
pythonGH-116683) If the `shutdown()` call happens before the worker thread starts executing the task, then nothing will be printed to stdout. (cherry picked from commit 7d1abe9) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-116693 is a backport of this pull request to the 3.11 branch. |
python#116683) If the `shutdown()` call happens before the worker thread starts executing the task, then nothing will be printed to stdout.
python#116683) If the `shutdown()` call happens before the worker thread starts executing the task, then nothing will be printed to stdout.
python#116683) If the `shutdown()` call happens before the worker thread starts executing the task, then nothing will be printed to stdout.
If the shutdown() call happens before the worker thread starts executing the task then nothing will be printed to stdout.