Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116941: Fix pyatomic_std.h syntax errors #116967

Merged
merged 1 commit into from
Mar 18, 2024
Merged

gh-116941: Fix pyatomic_std.h syntax errors #116967

merged 1 commit into from
Mar 18, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Mar 18, 2024 •
edited by bedevere-app bot
Loading

@colesbury colesbury requested a review from DinoV March 18, 2024 18:07
@bedevere-app bedevere-app bot mentioned this pull request Mar 18, 2024
Closed
@colesbury
Copy link
Contributor Author

Tested with:

CFLAGS="-D_Py_USE_GCC_BUILTIN_ATOMICS=0" ./configure --with-pydebug --disable-gil

Once @vstinner lands #116954, we may want to extend the test to also try compiling extensions with -D_Py_USE_GCC_BUILTIN_ATOMICS=0

vstinner
vstinner approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Oh wow, surprising that we missed that. But I remeber that the review was complicated and I modified the code, so it can be my fault :-)

@colesbury
Copy link
Contributor Author

It wasn't in the original pyatomic_std.h. I think it happened later when resolving a merge conflict.

@colesbury colesbury merged commit 165cb45 into python:main Mar 18, 2024
37 of 38 checks passed
@colesbury colesbury deleted the gh-116941-pyatomic-std branch March 18, 2024 21:05
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@colesbury @vstinner
pythongh-116941: Fix pyatomic_std.h syntax errors (python#116967)
56762b6
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@colesbury @adorilson
pythongh-116941: Fix pyatomic_std.h syntax errors (python#116967)
d2cc307
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@colesbury @diegorusso
pythongh-116941: Fix pyatomic_std.h syntax errors (python#116967)
98ce4c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@DinoV DinoV Awaiting requested review from DinoV

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @vstinner