bpo-30485: Re-allow empty strings in ElementPath namespace mappings #12830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
reviewed
Apr 14, 2019
Lib/test/test_xml_etree.py
Outdated
| with self.assertRaisesRegex(ValueError, 'namespace prefix'): | ||
| root.findall(".//xx:b", namespaces=nsmap) | ||
| #nsmap = {'xx': 'X', '': 'Y'} | ||
| #with self.assertRaisesRegex(ValueError, 'namespace prefix'): |
There was a problem hiding this comment.
Commented test sometimes causes confusion over it's existence. Perhaps remove the test since tbe ValueError is removed?
There was a problem hiding this comment.
I was planning to bring back the functionality ASAP, probably as a (deprecation?) warning. But I guess it's better to have a clean removal for now, as the discussion what to do about it is not urgent.
…ince they might actually be harmless and unused (and thus went undetected previously).
|
@scoder: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They might actually be harmless and unused (and thus went undetected previously).
https://bugs.python.org/issue30485