bpo-36624: Add platform constants in Lib/test/support (support.MS_WINDOWS, support.AIX, etc) #12843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't assign generations[2].threshold to generations[2].threshold: useless operation.
The imap.IMAP4.logout() method no longer ignores silently arbitrary exceptions. Changes: * The IMAP4.logout() method now expects a "BYE" untagged response, rather than relying on _check_bye() which raises a self.abort() exception. * IMAP4.__exit__() now does nothing if the client already logged out. * Add more debug info if test_logout() tests fail.
…12836) IPv4Interface and IPv6Interface did not has netmask and hostmask attributes when its argument is bytes or int. This commit extracts method for constructors of Network and Interface, and ensure Interface class always provides them.
Use literalinclude markup to include Tools/scripts/serve.py code. Tools/scripts/serve.py first argument on the command line is now optional.
aixtools
requested review from
gpshead,
rhettinger,
skrah and
a team
as code owners
Signed-off-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
It reduces "data" segment in python about 200KB.
Fix test_tabnanny on VxWorks: adjust ENOENT error message, use os.strerror().
shutil.which() and distutils.spawn.find_executable() now use
os.confstr("CS_PATH") if available instead of os.defpath, if the PATH
environment variable is not set.
Don't use os.confstr("CS_PATH") nor os.defpath if the PATH
environment variable is set to an empty string to mimick Unix 'which'
command behavior.
Changes:
* find_executable() now starts by checking for the executable in the
current working directly case. Add an explicit
"if not path: return None".
* Add tests for PATH='' (empty string), PATH=':' and for PATHEXT.
…11586) Document the change in a NEWS entry of the Security category.
subprocess.Popen doesn't support preexec on VxWorks.
Skip tests cases setting RLIMIT_FSIZE and RLIMIT_CPU on VxWorks.
Fix Python Initialization code on FreeBSD to detect properly when stdin file descriptor (fd 0) is invalid. On FreeBSD, fstat() must be used to check if stdin (fd 0) is valid. dup(0) doesn't fail if stdin is invalid in some cases.
…12853) Change PyAPI_FUNC(type), PyAPI_DATA(type) and PyMODINIT_FUNC macros of pyport.h when Py_BUILD_CORE_MODULE is defined. The Py_BUILD_CORE_MODULE define must be now be used to build a C extension as a dynamic library accessing Python internals: export the PyInit_xxx() function in DLL exports on Windows. Changes: * Py_BUILD_CORE_BUILTIN and Py_BUILD_CORE_MODULE now imply Py_BUILD_CORE directy in pyport.h. * ceval.c compilation now fails with an error if Py_BUILD_CORE is not defined, just to ensure that Python is build with the correct defines. * setup.py now compiles _pickle.c with Py_BUILD_CORE_MODULE define. * setup.py compiles _json.c with Py_BUILD_CORE_MODULE define, rather than Py_BUILD_CORE_BUILTIN define * PCbuild/pythoncore.vcxproj: Add Py_BUILD_CORE_BUILTIN define.
…eld (pythonGH-10340) When the future returned by shield is cancelled, its completion callback of the inner future is not removed. This makes the callback list of inner inner future grow each time a shield is created and cancelled. This change unregisters the callback from the inner future when the outer future is cancelled. https://bugs.python.org/issue35125
…#13169) * BPO-27639: Correct return type for UserList slicing operation Added logic to __getitem__ magic method for UserList to ensure that the return type matches that of self.
* bpo-36832: add zipfile.Path * bpo-36832: add documentation for zipfile.Path * 📜🤖 Added by blurb_it. * Remove module reference from blurb. * Sort the imports * Update docstrings and docs per recommendations. * Rely on test.support.temp_dir * Signal that 'root' is the parameter. * Correct spelling of 'mod' * Convert docstring to comment for brevity. * Fix more errors in the docs
aixtools
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ericvsmith,
gvanrossum,
ilevkivskyi,
ncoghlan,
pablogsal,
terryjreedy,
warsaw and
a team
as code owners
|
well, going to try to roll this back. Did not work the way it is suppossed to... Bah "rebase" :) |
|
OK - will need some help - I would rather NOT close this PR , throw away the current branch, and then submit the changes again in a new PR. I have all the changes in a patch file - and I can apply all of those to 'master'. I should have done 'rebase' differently - learning curve... Is there a clean way to do this - keeping this same PR - or is it just easier to close here, and start over - in a new PR? |
|
Closing the PR will remove the noise and undo the spurious review requests. It will not delete the current bpo-36624-support branch of your aixtools/cpython fork. If that branch was branched off of the master branch, you should be able update it by pull or fetch/merge upstream/master on your working machine and push to the fork. Then make a new PR, checking to make sure that the only commits that show on the comparison page before making the PR are your commits. |
|
Closing due to all the spurious review requests and the existing merge conflicts. |
|
I agree with @terryjreedy, this PR should be closed, and a new clean PR should be created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the first phase - an example of what could be - although I have added other constants as discussed during #7800.
During the previous discussion, backport was discussed, and if manual work is needed for the backport(s) I'll do that as well.
https://bugs.python.org/issue36624