bpo-36796: Clean the error handling in _testcapimodule.c #13085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, fix possible ref counting bugs in test_L_code() and test_k_code() -- it was possible for "num" to be decrefed twice.
|
The timezone portion of the changes looks good to me, haven't looked at the other parts. |
Modules/_testcapimodule.c
Outdated
|
|
||
| PyTuple_SET_ITEM(tuple, 0, num); | ||
| PyTuple_SetItem(tuple, 0, num); |
There was a problem hiding this comment.
Why it has been changed?
|
Hi, @serhiy-storchaka. Thank you for the review. This PR deals solely with missing failure checks and possible ref counting bugs. If it is desired to make other changes to some functions in _testcapimodule.c, then perhaps that should be handled in a separate issue. |
|
@serhiy-storchaka do you continue to review the PR of @ZackerySpytz ? Thank you |
serhiy-storchaka
added
skip news
needs backport to 3.12
serhiy-storchaka
approved these changes
Dec 14, 2023
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-113132 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 14, 2023
) (cherry picked from commit a723a13) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 14, 2023
corona10
pushed a commit
to corona10/cpython
that referenced
this pull request
Dec 15, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, fix possible ref counting bugs in test_L_code() and
test_k_code() -- it was possible for "num" to be decrefed twice.
https://bugs.python.org/issue36796