Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36799: Fix typo in ctypes.rst #13104

Merged
merged 1 commit into from
May 15, 2019
Merged

bpo-36799: Fix typo in ctypes.rst #13104

merged 1 commit into from
May 15, 2019

Conversation

sehnsucht13
Copy link
Contributor

@sehnsucht13 sehnsucht13 commented May 6, 2019 •
edited by bedevere-bot

This addresses bpo-36799: Fix two misspellings in the ctypes.rst file within the python documentation.

https://bugs.python.org/issue36799

@sehnsucht13
Fix documentation typo in ctypes.rst
b6bf057 
This addresses bpo-36799.
There were two mispellings in the ctypes.rst file within the python
documentation.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 6, 2019
@sehnsucht13
Copy link
Contributor Author

Just as a heads up, I just signed the CLA today(Sunday, May 5 at roughly 8:00 PDT) so it has not been reviewed yet.

tirkarthi
tirkarthi approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@matrixise matrixise changed the title Fix documentation typo in ctypes.rst bpo-36799: Fix typo in ctypes.rst May 15, 2019
matrixise
matrixise approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@matrixise matrixise merged commit 133fc89 into python:master May 15, 2019
@miss-islington
Copy link
Contributor

Thanks @sehnsucht13 for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

matrixise pushed a commit to matrixise/cpython that referenced this pull request May 15, 2019
@sehnsucht13 @matrixise
[3.7] bpo-36799: Fix typo in ctypes.rst (pythonGH-13104)
7c29d27 
(cherry picked from commit 133fc89)

Co-authored-by: Yavor Konstantinov <7553015+sehnsucht13@users.noreply.github.com>
@bedevere-bot
Copy link

GH-13341 is a backport of this pull request to the 3.7 branch.

matrixise added a commit that referenced this pull request May 15, 2019
@matrixise @sehnsucht13
[3.7] bpo-36799: Fix typo in ctypes.rst (GH-13104) (GH-13341)
4fd7f56 
(cherry picked from commit 133fc89)

Co-authored-by: Yavor Konstantinov <7553015+sehnsucht13@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrixise matrixise matrixise approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sehnsucht13 @the-knights-who-say-ni @miss-islington @bedevere-bot @matrixise @tirkarthi @csabella