-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-20443: make code objects filename an absolute path #13527
Conversation
The compiler isn't an appropriate place to do this. |
Then, where to it'll return absolute path? For not breaking backwards compability, we can set up a future flag if it is OK? |
I think you meant, where to patch to that co_filename == ? I agree with what Benjamin implied, that the call site should pass in the absolute patch when there is one. The passed-in 'filename' can be anything and does not have to correspond to a real file on external storage.
This would definitely require a PEP. |
I know, i posted to python-ideas. |
I concur with Benjamin: code object constructor is the wrong place to fix the issue. The filename must be made absolute somewhere in the caller. I'm not against https://bugs.python.org/issue20443 I'm only against the proposed implementation. |
make code objects filename an absolute path
https://bugs.python.org/issue20443