Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37045: PEP 591: Add final qualifiers to typing module #13571

Merged
merged 6 commits into from
May 26, 2019

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented May 25, 2019

cc @msullivan

The implementation is straightforward, it just mimics ClassVar (since the latter is also a name/access qualifier, not really a type). Also it is essentially copied from typing_extensions.

https://bugs.python.org/issue37045

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some doc nits. (The PR is almost all docs anyway. ;-) Feel free to fix those and merge.

Doc/library/typing.rst Outdated Show resolved Hide resolved
Lib/typing.py Outdated Show resolved Hide resolved
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@ilevkivskyi ilevkivskyi merged commit f367242 into python:master May 26, 2019
@ilevkivskyi ilevkivskyi deleted the add-final branch May 26, 2019 08:37
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…3571)

The implementation is straightforward, it just mimics `ClassVar` (since the latter is also a name/access qualifier, not really a type). Also it is essentially copied from `typing_extensions`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants