Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [streams] (GH-13671) #13833

Merged
merged 1 commit into from
Jun 5, 2019
Merged

[3.8] bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [streams] (GH-13671) #13833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Lib/asyncio/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ async def open_connection(host=None, port=None, *,
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
else:
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)
reader = StreamReader(limit=limit, loop=loop)
protocol = StreamReaderProtocol(reader, loop=loop, _asyncio_internal=True)
transport, _ = await loop.create_connection(
Expand Down Expand Up @@ -213,6 +217,10 @@ async def start_server(client_connected_cb, host=None, port=None, *,
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
else:
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)

def factory():
reader = StreamReader(limit=limit, loop=loop)
Expand Down Expand Up @@ -414,6 +422,10 @@ async def open_unix_connection(path=None, *,
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
else:
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)
reader = StreamReader(limit=limit, loop=loop)
protocol = StreamReaderProtocol(reader, loop=loop,
_asyncio_internal=True)
Expand Down Expand Up @@ -473,6 +485,10 @@ async def start_unix_server(client_connected_cb, path=None, *,
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
else:
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)

def factory():
reader = StreamReader(limit=limit, loop=loop)
Expand Down