Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-26219: Fix compiler warning in _PyCode_InitOpcache() #13997

Merged
merged 1 commit into from
Jun 12, 2019
Merged

bpo-26219: Fix compiler warning in _PyCode_InitOpcache() #13997

merged 1 commit into from
Jun 12, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 12, 2019 •
edited by bedevere-bot

Fix MSVC warning:

objects\codeobject.c(285): warning C4244: '=':
conversion from 'Py_ssize_t' to 'unsigned char',
possible loss of data

https://bugs.python.org/issue26219

@vstinner
bpo-26219: Fix compiler warning in _PyCode_InitOpcache()
8d9621f 
Fix MSVC warning:

    objects\codeobject.c(285): warning C4244: '=':
    conversion from 'Py_ssize_t' to 'unsigned char',
    possible loss of data
@vstinner vstinner merged commit 376ce98 into python:master Jun 12, 2019
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the code_warn branch June 12, 2019 02:41
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2019
@vstinner @miss-islington
bpo-26219: Fix compiler warning in _PyCode_InitOpcache() (pythonGH-13997
f07d9e1 
)

Fix MSVC warning:

    objects\codeobject.c(285): warning C4244: '=':
    conversion from 'Py_ssize_t' to 'unsigned char',
    possible loss of data
(cherry picked from commit 376ce98)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

GH-14000 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jun 12, 2019
vstinner added a commit that referenced this pull request Jun 12, 2019
@miss-islington @vstinner
bpo-26219: Fix compiler warning in _PyCode_InitOpcache() (GH-13997) (G…
996e526 
…H-14000)

Fix MSVC warning:

    objects\codeobject.c(285): warning C4244: '=':
    conversion from 'Py_ssize_t' to 'unsigned char',
    possible loss of data
(cherry picked from commit 376ce98)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@vstinner @lisroach
bpo-26219: Fix compiler warning in _PyCode_InitOpcache() (pythonGH-13997
154df65 
)

Fix MSVC warning:

    objects\codeobject.c(285): warning C4244: '=':
    conversion from 'Py_ssize_t' to 'unsigned char',
    possible loss of data
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
bpo-26219: Fix compiler warning in _PyCode_InitOpcache() (pythonGH-13997
1055385 
)

Fix MSVC warning:

    objects\codeobject.c(285): warning C4244: '=':
    conversion from 'Py_ssize_t' to 'unsigned char',
    possible loss of data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni