Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37250: define tp_print for backwards compatibility #14009

Closed
wants to merge 1 commit into from
Closed

bpo-37250: define tp_print for backwards compatibility #14009

wants to merge 1 commit into from

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Jun 12, 2019 •
edited by vstinner
Loading

bugfix for 3.8, so needs backport.

https://bugs.python.org/issue37250

@mangrisano
Copy link
Contributor

/cc @vstinner

vstinner
vstinner reviewed Jun 12, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cython cannot be fixed instead? I am not sure that I like reintroducing tp_print, it is unused for 10 years...

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jun 12, 2019 •
edited by bedevere-bot
Loading

Cython cannot be fixed instead?

This is being discussed at bpo-37221, please discuss there.

@vstinner
Copy link
Member

Please open a separated issue, https://bugs.python.org/issue37221 is about PyCode_New

@vstinner
Copy link
Member

I created https://bugs.python.org/issue37250

@vstinner vstinner changed the title bpo-37221: define tp_print for backwards compatibility bpo-37250: define tp_print for backwards compatibility Jun 12, 2019
@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jun 18, 2019 •
edited by bedevere-bot
Loading

Rejected on bpo-37250

@jdemeyer jdemeyer closed this Jun 18, 2019
@ThomasWaldmann ThomasWaldmann mentioned this pull request Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdemeyer @mangrisano @vstinner @the-knights-who-say-ni @bedevere-bot