Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37324: Remove ABC aliases from collections #14171

Closed
wants to merge 1 commit into from
Closed

bpo-37324: Remove ABC aliases from collections #14171

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 17, 2019

Remove deprecated aliases to Abstract Base Classes from the
collections module.

https://bugs.python.org/issue37324

Remove deprecated aliases to Abstract Base Classes from the
collections module.
@vstinner
Copy link
Member Author

pip is broken by this change, causing test_venv to fail: https://bugs.python.org/issue37324#msg345906

@tirkarthi
Copy link
Member

Vendored html5lib in pip was fixed upstream but needs a new release to fix thjs. See also discussion at #10596

@vstinner
Copy link
Member Author

Oh. I wasn't aware of the previous attempt: #10596 there is a long discussion there.

Vendored html5lib in pip was fixed upstream but needs a new release to fix thjs. See also discussion at #10596

I also found some info about that: https://bugs.python.org/issue37324#msg345908

@vstinner
Copy link
Member Author

It seems like jinja2 should be updated:

/home/vstinner/prog/python/master/env/lib/python3.9/site-packages/jinja2/utils.py:485: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
  from collections import MutableMapping

/home/vstinner/prog/python/master/env/lib/python3.9/site-packages/jinja2/runtime.py:318: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
  from collections import Mapping

/home/vstinner/prog/python/master/env/lib/python3.9/site-packages/jinja2/sandbox.py:82: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
  from collections import MutableSet, MutableMapping, MutableSequence

@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Jun 21, 2019
@vstinner
Copy link
Member Author

This PR cannot be merged because it breaks the Python CI because of html5lib (used by pip): https://bugs.python.org/issue37324#msg348011 I prefer to close this PR right now. I will not be available next weeks, so I prefer to close the PR. I may reopen it later, once html5lib and pip are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants