Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30389 Adds detection of VS 2017 #1632

Merged
merged 17 commits into from
Sep 7, 2017
Merged

bpo-30389 Adds detection of VS 2017 #1632

merged 17 commits into from
Sep 7, 2017

Conversation

zooba
Copy link
Member

@zooba zooba commented May 17, 2017 •
edited by bedevere-bot
Loading

@mention-bot
Copy link

@zooba, thanks for your PR! By analyzing the history of the files in this pull request, we identified @larryhastings, @briancurtin and @tiran to be potential reviewers.

pitrou
pitrou reviewed May 28, 2017
View reviewed changes
PC/_findvs.cpp Outdated

#include <Python.h>

PyObject *error_from_hr(HRESULT hr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these functions should be static.

@zooba
Copy link
Member Author

zooba commented Jun 2, 2017

Do not merge. The faulthandler module is detecting non-fatal errors and causing the tests to fail. We need to fix that first before merging.

@zooba
Copy link
Member Author

zooba commented Jun 8, 2017

This is ready to merge now, unless others have feedback. @pitrou @zware

@zooba zooba requested review from rhettinger, skrah and a team as code owners September 7, 2017 00:05
@zooba zooba closed this Sep 7, 2017
@zooba zooba reopened this Sep 7, 2017
zware
zware reviewed Sep 7, 2017
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as far as I can tell, but it's mostly beyond me.

@zooba zooba merged commit 05f01d8 into python:master Sep 7, 2017
@miss-islington
Copy link
Contributor

🐍🍒⛏🤖 Thanks @zooba for the PR, and @zooba for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

@miss-islington
Copy link
Contributor

Sorry, @zooba and @zooba, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.

@zooba zooba deleted the find-vs2017 branch September 7, 2017 18:52
zooba added a commit to zooba/cpython that referenced this pull request Sep 7, 2017
@zooba
bpo-30389 Adds detection of VS 2017 to distutils._msvccompiler (pytho…
19fe9bf 
…n#1632)
@zooba zooba mentioned this pull request Sep 7, 2017
Merged
zooba added a commit that referenced this pull request Sep 7, 2017
@zooba
[3.6] bpo-30389 Adds detection of VS 2017 to distutils._msvccompiler G…
76006f2 
…H-1632 (#3425)
@ariddell ariddell mentioned this pull request Sep 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou left review comments

@zware zware zware left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zooba @mention-bot @miss-islington @pitrou @zware @serhiy-storchaka @the-knights-who-say-ni