[3.8] bpo-38242: Revert new asyncio streaming API #16445
Conversation
Reverts changes made in 3.8 to asyncio streams (23b4b69).
…ython#13672)" This reverts commit ed9f356.
aeros
requested review from
1st1,
asvetlov,
gpshead and
tiran
as code owners
|
Kyle, the PR should be against the |
| .. coroutinefunction:: start_server(client_connected_cb, host=None, \ | ||
| port=None, \*, loop=None, limit=2**16, \ | ||
| port=None, \*, loop=None, limit=None, \ |
There was a problem hiding this comment.
Can the change to the default value of limit be retained? I wasn't sure about this one, so I figured it would be best to ask first.
aeros
changed the title
|
All merge conflicts have been resolved. |
| @@ -30,27 +30,21 @@ def check_all(self, modname): | |||
| raise NoAll(modname) | |||
| names = {} | |||
| with self.subTest(module=modname): | |||
| with support.check_warnings( | |||
There was a problem hiding this comment.
@1st1 can the changes from lines 33-53 remain? This is unrelated to the streaming API.
Are you certain? The conflicts in 3.9 will probably take significantly longer to resolve (since there will likely be additional ones), so if we want to get the patch through ASAP it might be better to do it manually against 3.8 first. |
|
I'll close this one and create a new one against 3.9. It should be a bit easier since I figured out exactly what commits to revert. Let me know if this one should be reopened. |
Thanks. We want to keep |
|
New PR: #16455 |
Motivation: Comment in bpo issue from @1st1:
Reverts the following commits from 3.8:
Merge asyncio streams (primary reversion):
23b4b69
Documentation:
b9bfe14
7268fd0
ed9f356
Minor test changes (incompatible with
asyncio.StreamReaderandasyncio.StreamWriter):4cdbc452ce3
Manual resolution of several conflicts was also required, the majority were for retaining the the deprecation of explicitly passing the loop argument for tasks (345bfc9). There were a few others as well.
This PR must be carefully reviewed, especially since it is removing multiple tests that no longer function properly without the changes made in 23b4b69. It is important to be 100% certain that no additional tests were removed. I believe @asvetlov would be the most qualified individual to verify the tests are in a correct state, since he wrote the majority of the tests related to the new streaming API.
I believe it is most of the way there, but additional changes may be needed before it is complete. Until we are certain, I am adding the
DO-NOT-MERGElabel.To @1st1 and @asvetlov:
I have enabled "Allow edits from maintainers" (as I usually do). Please feel free to directly commit changes into the PR. I would appreciate review feedback so that I can understand the reasons behind any changes made, but you certainly don't have to wait on me to make any changes to the PR. Especially since this is a release blocker for 3.8.0.
https://bugs.python.org/issue38242