Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37105: Add deprecated-remove information on stream doc #13672

Merged
merged 3 commits into from May 31, 2019
Merged

bpo-37105: Add deprecated-remove information on stream doc #13672

merged 3 commits into from May 31, 2019

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented May 30, 2019 •
edited by bedevere-bot

According to the code on streams.py the functions:
open_connection(), start_server(), open_unix_connection(),
start_unix_server() are deprecated. I inform that on
documentation.

https://bugs.python.org/issue37105

@eamanu
Add deprecated-remove information on stream doc
a99b612 
According to the code on streams.py the functions:
``open_connection()``, ``start_server()``, ``open_unix_connection()``,
``start_unix_server()`` are deprecated. I infor that on
documentation.
@eamanu eamanu requested review from 1st1 and asvetlov as code owners May 30, 2019 01:59
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 30, 2019
@eamanu
Copy link
Contributor Author

eamanu commented May 31, 2019

I think the news could be skipped

I will open a bpo

@eamanu eamanu changed the title Add deprecated-remove information on stream doc bpo-37105: Add deprecated-remove information on stream doc May 31, 2019
asvetlov
asvetlov approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is: the new stream API is not documented yet :)
I'm merging this PR but we need to write docs for new streams before release candidate.
Any help is welcome as usual

@asvetlov asvetlov merged commit ed9f356 into python:master May 31, 2019
@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@eamanu
Copy link
Contributor Author

eamanu commented May 31, 2019 •
edited

The problem is: the new stream API is not documented yet :)

@asvetlov I will take this :-)

@eamanu eamanu deleted the add-deprectated branch May 31, 2019 22:28
aeros added a commit to aeros/cpython that referenced this pull request Sep 27, 2019
@aeros
Revert "bpo-37105: Add deprecated-remove information on stream doc (p…
22a78e0 
…ython#13672)"

This reverts commit ed9f356.
aeros added a commit to aeros/cpython that referenced this pull request Sep 28, 2019
@aeros
Revert "bpo-37105: Add deprecated-remove information on stream doc (p…
4fb43ff 
…ython#13672)"

This reverts commit ed9f356.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@eamanu @DinoV
bpo-37105: Add deprecated-remove information on stream doc (python#13672
9dd928a 
)

* Add deprecated-remove information on stream doc

According to the code on streams.py the functions:
``open_connection()``, ``start_server()``, ``open_unix_connection()``,
``start_unix_server()`` are deprecated. I infor that on
documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau approved these changes

@asvetlov asvetlov asvetlov approved these changes

@auvipy auvipy auvipy approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eamanu @bedevere-bot @Carreau @asvetlov @auvipy @the-knights-who-say-ni