Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38312: Add curses.{get,set}_escdelay and curses.{get,set}_tabsize #16938

Merged
merged 1 commit into from
Oct 31, 2019
Merged

bpo-38312: Add curses.{get,set}_escdelay and curses.{get,set}_tabsize #16938

merged 1 commit into from
Oct 31, 2019

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Oct 26, 2019 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka reviewed Oct 29, 2019
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and a What's New entry.

Modules/_cursesmodule.c Outdated Show resolved Hide resolved
@asottile
Copy link
Contributor Author

Please add tests and a What's New entry.

For tests I'm not sure it's possible to demonstrate the behaviour -- should I just call the functions and ensure they don't crash?

@serhiy-storchaka
Copy link
Member

Yes, testing that functions exist and do not crash is the minimum. Many functions in the curses module do not have better testing.

@asottile
Copy link
Contributor Author

tests and what's new added \o/ -- thanks for the review :)

@asottile asottile changed the title bpo-38312: Add curses.set_escdelay and curses.set_tabsize bpo-38312: Add curses.{get,set}_escdelay and curses.{get,set}_tabsize Oct 29, 2019
serhiy-storchaka
serhiy-storchaka reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add also versionadded to get_escdelay and get_tabsize.

Oh, seems there is no get_tabsize in ncurses. But it is okay.

@asottile
Copy link
Contributor Author

Add also versionadded to get_escdelay and get_tabsize.

oops! added :)

@serhiy-storchaka serhiy-storchaka merged commit b32cb97 into python:master Oct 31, 2019
@serhiy-storchaka
Copy link
Member

Thanks @asottile!

@asottile asottile deleted the tabsize_escdelay branch October 31, 2019 14:21
@asottile asottile mentioned this pull request Nov 2, 2019
Closed
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@asottile
bpo-38312: Add curses.{get,set}_escdelay and curses.{get,set}_tabsize. (
7aca763 
pythonGH-16938)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@asottile @shihai1991
bpo-38312: Add curses.{get,set}_escdelay and curses.{get,set}_tabsize. (
4da2d2f 
pythonGH-16938)
@asottile asottile mentioned this pull request Nov 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asottile @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot