-
-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-30466: Add brief explanation of classes to tutorial #1804
bpo-30466: Add brief explanation of classes to tutorial #1804
Conversation
@treyhunner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @avassalotti and @serhiy-storchaka to be potential reviewers. |
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
I think the change here looks good. Raymond indicated in the issue that he wants to review this, so I'll wait for his feedback :) |
@@ -4,6 +4,12 @@ | |||
Classes | |||
******* | |||
|
|||
Classes provide a means of bundling data and functionality together. Creating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this, wouldn't the flow be more natural if this was the second paragraph and not the first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think starting with a brief intro of what classes are, like this paragraph here, is good.
Thanks @treyhunner and congrats on your first contribution to CPython 🎉 Can you please backport this to the 3.6 branch? You can use cherry_picker. |
This could certainly use more work. A "what are classes" or "why classes" section would be great, especially one that explains the various class terminology.
We could alternatively or additionally link to external resources that explain classes at a beginner-friendly level.
The "A First Look at Classes" section could also probably be moved up the page or it could be noted that beginners can skip over the first couple sections before it.